-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Marketo: set high test strictness level #21790
Merged
lazebnyi
merged 6 commits into
master
from
ddavydov/#19055-source-marketo-high-test-strictness-level
Jan 26, 2023
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bd25ad7
#19055 source marketo: set high test strictness level
davydov-d 2a60aca
#19055 source marketo: increase incremental test timeout
davydov-d f36ce29
#19055 source Marketo: fix stream schemas
davydov-d 42d9ab7
#19055 source marketoL fix unit test
davydov-d 6271745
Updated expected records
lazebnyi 019c8fb
Updated expected records
lazebnyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
92 changes: 72 additions & 20 deletions
92
airbyte-integrations/connectors/source-marketo/acceptance-test-config.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,81 @@ | ||
# See [Source Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/source-acceptance-tests-reference) | ||
# for more information about how to configure these tests | ||
connector_image: airbyte/source-marketo:dev | ||
tests: | ||
test_strictness_level: high | ||
acceptance_tests: | ||
spec: | ||
- spec_path: "source_marketo/spec.json" | ||
tests: | ||
- spec_path: "source_marketo/spec.json" | ||
connection: | ||
- config_path: "secrets/config.json" | ||
status: "succeed" | ||
- config_path: "integration_tests/invalid_config.json" | ||
status: "failed" | ||
tests: | ||
- config_path: "secrets/config.json" | ||
status: "succeed" | ||
- config_path: "integration_tests/invalid_config.json" | ||
status: "failed" | ||
discovery: | ||
- config_path: "secrets/config.json" | ||
tests: | ||
- config_path: "secrets/config.json" | ||
basic_read: | ||
- config_path: "secrets/config.json" | ||
configured_catalog_path: "integration_tests/configured_catalog.json" | ||
empty_streams: ["lists", "campaigns"] | ||
timeout_seconds: 3600 | ||
expect_records: | ||
path: "integration_tests/expected_records.jsonl" | ||
tests: | ||
- config_path: "secrets/config.json" | ||
expect_records: | ||
path: "integration_tests/expected_records.jsonl" | ||
empty_streams: | ||
- name: "activities_update_opportunity" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_change_segment" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_document_interacted_with" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_call_webhook" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_push_leadto_marketo" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_change_revenue_stage" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_dialogue_goal_reached" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_removefrom_opportunity" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_received_forwardto_friend_email" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_open_sales_email" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_share_content" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_sales_email_bounced" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_dialogue_engaged" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_dialogue_appointment_scheduled" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_click_sales_email" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_sent_forwardto_friend_email" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_click_link" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_send_sales_email" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_change_revenue_stage_manually" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_receive_sales_email" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_replyto_sales_email" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_addto_opportunity" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
- name: "activities_open_email" | ||
bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction" | ||
Comment on lines
+66
to
+69
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. dang. |
||
# 52 streams, most of them use BULK API therefore it takes much time to run a sync | ||
timeout_seconds: 9000 | ||
incremental: | ||
- config_path: "secrets/config.json" | ||
configured_catalog_path: "integration_tests/incremental_catalog.json" | ||
future_state_path: "integration_tests/abnormal_state.json" | ||
timeout_seconds: 3600 | ||
tests: | ||
- config_path: "secrets/config.json" | ||
configured_catalog_path: "integration_tests/incremental_catalog.json" | ||
future_state: | ||
future_state_path: "integration_tests/abnormal_state.json" | ||
full_refresh: | ||
- config_path: "secrets/config.json" | ||
configured_catalog_path: "integration_tests/configured_catalog.json" | ||
timeout_seconds: 3600 | ||
tests: | ||
- config_path: "secrets/config.json" | ||
configured_catalog_path: "integration_tests/configured_catalog.json" |
35 changes: 0 additions & 35 deletions
35
airbyte-integrations/connectors/source-marketo/integration_tests/catalog.json
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@igrankova managed to populate 29 streams, but another 23 streams can not be populated without leads/customers/etc interaction