Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sleep and repeat test to check non flakyness #19454

Merged
merged 2 commits into from
Nov 16, 2022
Merged

remove sleep and repeat test to check non flakyness #19454

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dc08c7
remove sleep and repeat test to check non flakyness
benmoriceau Nov 15, 2022
e97cdc9
Remove repeated test
benmoriceau Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions airbyte-tests/src/acceptanceTests/java/io/airbyte/test/acceptance/BasicAcceptanceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,9 +688,6 @@ void testDeleteConnection() throws Exception {
// connectionIds.remove(connectionId); // todo remove
testHarness.removeConnection(connectionId);

LOGGER.info("Waiting for connection to be deleted...");
Thread.sleep(5000);

ConnectionStatus connectionStatus =
apiClient.getConnectionApi().getConnection(new ConnectionIdRequestBody().connectionId(connectionId)).getStatus();
assertEquals(ConnectionStatus.DEPRECATED, connectionStatus);
Expand All @@ -710,9 +707,6 @@ void testDeleteConnection() throws Exception {
// we should still be able to delete the connection when the temporal workflow is in this state
apiClient.getConnectionApi().deleteConnection(new ConnectionIdRequestBody().connectionId(connectionId));

LOGGER.info("Waiting for connection to be deleted...");
Thread.sleep(5000);

connectionStatus = apiClient.getConnectionApi().getConnection(new ConnectionIdRequestBody().connectionId(connectionId)).getStatus();
assertEquals(ConnectionStatus.DEPRECATED, connectionStatus);
}
Expand Down