Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🎨 Use StepIndicator for connection setup steps #19285

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Nov 10, 2022

What

Introduces a new StepIndicator, which is a leightweight way of presenting which step is current active. This replaces the currently used StepMenu in the Connection Creation flow.

screenshot-20221110-141038

The step title will be shown in a tooltip on hover:

screenshot-20221110-144011

Why?

For a couple of reasons:

  • We see in FullStory regularily that people think they could navigate through those steps by clicking the which they can't given it's only an indicator.
  • The old indicator was specifically once the documentation panel was extended looking quiet squished because it wrote out all the titles in way too less space. Given that our primary focus is to show the user their progress and how (little) steps they have, we don't need all the indidivual step names present all the time.
  • This helps us stripping down the StepMenu into a now proper interactive Tab component, since it doesn't fulfill the weird double function as a step indicator anymore.

@timroes timroes requested a review from a team as a code owner November 10, 2022 13:56
@github-actions github-actions bot added the area/platform issues related to the platform label Nov 10, 2022
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in storybook. Only complaint is light mode seems to have large styling differences that I feel are not clear from the name "light"

@timroes
Copy link
Contributor Author

timroes commented Nov 10, 2022

@krishnaglick sorry not sure I can follow. This component doesn't have any light mode? So not sure what exactly you're referring to?

@krishnaglick
Copy link
Contributor

@krishnaglick sorry not sure I can follow. This component doesn't have any light mode? So not sure what exactly you're referring to?

Oh, I tested StepsMenu, not StepsIndicator! Re-tested and looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform team/platform-move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants