🪟 🐛 Fix validation when setting the connection stream cursor or primary key #18933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move changedStreams from CatalogTreeBody to CatalogTree so that the order of the changedStreams is based on the correct order
github-actions
bot
added
area/platform
teallarson
reviewed
Nov 3, 2022
| .sort(naturalComparatorBy((syncStream) => syncStream.stream?.name ?? "")), | ||
| connection.syncCatalog.streams | ||
| .filter((s) => s.config?.selected) | ||
| .sort(naturalComparatorBy((syncStream) => syncStream.stream?.name ?? "")) |
There was a problem hiding this comment.
I'm not sure I understand why these no longer need the sort. The only place I see us sorting now is the catalogTree. Isn't there still a chance that the order is not preserved between the connection object and the form values?
There was a problem hiding this comment.
The reason why this was sorted in the first place was that the formValues data was getting mutated by the sort call in the CatalogTree component. The formValues now contain same stream order as received in the connection object, and the order should match.
|
Tested locally and the bug does seem to be gone. Just one question to make sure we're covering all our bases! |
teallarson
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Related to https://github.com/airbytehq/oncall/issues/948
This fixes an issue related to validation not running when the connection stream primary key or cursor field is not set.
How
The validation was happening in the wrong order because the form initial values streams were being sorted when the CatalogTree component rendered. Instead, now it makes a copy of the array before sorting since sorting is one of those weird functions that is done in place.