Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bmoric/extract healt api #18523

Merged
merged 37 commits into from
Oct 28, 2022
Merged
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
4ebf4ec
Tmp
benmoriceau Oct 21, 2022
6d8e907
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau Oct 24, 2022
d930c98
Extract the Attempt API from the V1 API
benmoriceau Oct 24, 2022
2dba567
Add comments
benmoriceau Oct 24, 2022
7c36975
Move Connection API out of configuration API
benmoriceau Oct 24, 2022
0d87509
format
benmoriceau Oct 24, 2022
cf61847
Merge branch 'bmoric/convert-server-to-micronaut' of github.com:airby…
benmoriceau Oct 24, 2022
04e9bb2
format
benmoriceau Oct 24, 2022
c74db48
Rename to Controller
benmoriceau Oct 25, 2022
433dfe5
Merge branch 'bmoric/convert-server-to-micronaut' of github.com:airby…
benmoriceau Oct 25, 2022
415e0c7
Rename to Controller
benmoriceau Oct 25, 2022
7211da6
Add values to the factory
benmoriceau Oct 25, 2022
f503b4c
Change the constructor to use hadler instead of objects needed by the…
benmoriceau Oct 25, 2022
70ce157
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/ext…
benmoriceau Oct 25, 2022
688f812
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/ext…
benmoriceau Oct 25, 2022
2103e7d
Update with new tags.
benmoriceau Oct 25, 2022
a5c8522
tmp
benmoriceau Oct 25, 2022
c5aee8f
Fix PMD errors
benmoriceau Oct 25, 2022
50fc3ae
Extract DB migrator
benmoriceau Oct 25, 2022
6b11154
Merge branch 'bmoric/extract-connection-api' of github.com:airbytehq/…
benmoriceau Oct 25, 2022
4e8051e
Add something that I forgot
benmoriceau Oct 26, 2022
99d9d4b
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/ext…
benmoriceau Oct 26, 2022
aca18c9
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/ext…
benmoriceau Oct 26, 2022
7254ebb
extract destination definition api
benmoriceau Oct 26, 2022
4d748af
restore destination factory initialization
benmoriceau Oct 26, 2022
e6a56a2
extract destination definition specification api
benmoriceau Oct 26, 2022
709cdc4
format
benmoriceau Oct 26, 2022
aa06c20
Merge branch 'bmoric/extract-db-migration-api' of github.com:airbyteh…
benmoriceau Oct 26, 2022
82360dc
format
benmoriceau Oct 26, 2022
82ccd82
Merge branch 'bmoric/extract-destination-definition-api' of github.co…
benmoriceau Oct 26, 2022
6ecdb17
format
benmoriceau Oct 26, 2022
187c9ea
extract health check api
benmoriceau Oct 26, 2022
8023bc9
fix test
benmoriceau Oct 27, 2022
bd206a9
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/ext…
benmoriceau Oct 27, 2022
293c187
format
benmoriceau Oct 27, 2022
89308f5
Merge branch 'master' into bmoric/extract-healt-api
benmoriceau Oct 28, 2022
c3cd08e
Merge branch 'master' into bmoric/extract-healt-api
benmoriceau Oct 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,13 @@ public class ConfigurationApiFactory implements Factory<ConfigurationApi> {
private static SynchronousSchedulerClient synchronousSchedulerClient;
private static StatePersistence statePersistence;
private static Map<String, String> mdc;
private static Database configsDatabase;
private static Database jobsDatabase;
private static TrackingClient trackingClient;
private static WorkerEnvironment workerEnvironment;
private static LogConfigs logConfigs;
private static Path workspaceRoot;
private static AirbyteVersion airbyteVersion;
private static HttpClient httpClient;
private static EventRunner eventRunner;
private static Flyway configsFlyway;
private static Flyway jobsFlyway;

public static void setValues(
final ConfigRepository configRepository,
Expand All @@ -70,17 +66,13 @@ public static void setValues(
ConfigurationApiFactory.secretsRepositoryWriter = secretsRepositoryWriter;
ConfigurationApiFactory.synchronousSchedulerClient = synchronousSchedulerClient;
ConfigurationApiFactory.mdc = mdc;
ConfigurationApiFactory.configsDatabase = configsDatabase;
ConfigurationApiFactory.jobsDatabase = jobsDatabase;
ConfigurationApiFactory.trackingClient = trackingClient;
ConfigurationApiFactory.workerEnvironment = workerEnvironment;
ConfigurationApiFactory.logConfigs = logConfigs;
ConfigurationApiFactory.workspaceRoot = workspaceRoot;
ConfigurationApiFactory.airbyteVersion = airbyteVersion;
ConfigurationApiFactory.httpClient = httpClient;
ConfigurationApiFactory.eventRunner = eventRunner;
ConfigurationApiFactory.configsFlyway = configsFlyway;
ConfigurationApiFactory.jobsFlyway = jobsFlyway;
ConfigurationApiFactory.statePersistence = statePersistence;
}

Expand All @@ -94,18 +86,14 @@ public ConfigurationApi provide() {
ConfigurationApiFactory.secretsRepositoryReader,
ConfigurationApiFactory.secretsRepositoryWriter,
ConfigurationApiFactory.synchronousSchedulerClient,
ConfigurationApiFactory.configsDatabase,
ConfigurationApiFactory.jobsDatabase,
ConfigurationApiFactory.statePersistence,
ConfigurationApiFactory.trackingClient,
ConfigurationApiFactory.workerEnvironment,
ConfigurationApiFactory.logConfigs,
ConfigurationApiFactory.airbyteVersion,
ConfigurationApiFactory.workspaceRoot,
ConfigurationApiFactory.httpClient,
ConfigurationApiFactory.eventRunner,
ConfigurationApiFactory.configsFlyway,
ConfigurationApiFactory.jobsFlyway);
ConfigurationApiFactory.eventRunner);
}

@Override
Expand Down
12 changes: 12 additions & 0 deletions airbyte-server/src/main/java/io/airbyte/server/ServerApp.java
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@
import io.airbyte.server.handlers.AttemptHandler;
import io.airbyte.server.handlers.ConnectionsHandler;
import io.airbyte.server.handlers.DbMigrationHandler;
import io.airbyte.server.handlers.DestinationDefinitionsHandler;
import io.airbyte.server.handlers.DestinationHandler;
import io.airbyte.server.handlers.HealthCheckHandler;
import io.airbyte.server.handlers.OperationsHandler;
import io.airbyte.server.handlers.SchedulerHandler;
import io.airbyte.server.scheduler.DefaultSynchronousSchedulerClient;
Expand Down Expand Up @@ -293,6 +295,13 @@ public static ServerRunnable getServer(final ServerFactory apiFactory,
configs.getLogConfigs(),
eventRunner);

final DbMigrationHandler dbMigrationHandler = new DbMigrationHandler(configsDatabase, configsFlyway, jobsDatabase, jobsFlyway);

final DestinationDefinitionsHandler destinationDefinitionsHandler = new DestinationDefinitionsHandler(configRepository, syncSchedulerClient,
destinationHandler);

final HealthCheckHandler healthCheckHandler = new HealthCheckHandler(configRepository);

LOGGER.info("Starting server...");

return apiFactory.create(
Expand All @@ -314,7 +323,10 @@ public static ServerRunnable getServer(final ServerFactory apiFactory,
jobsFlyway,
attemptHandler,
connectionsHandler,
dbMigrationHandler,
destinationDefinitionsHandler,
destinationHandler,
healthCheckHandler,
operationsHandler,
schedulerHandler);
}
Expand Down
53 changes: 49 additions & 4 deletions airbyte-server/src/main/java/io/airbyte/server/ServerFactory.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,31 @@
import io.airbyte.server.apis.AttemptApiController;
import io.airbyte.server.apis.ConfigurationApi;
import io.airbyte.server.apis.ConnectionApiController;
import io.airbyte.server.apis.DbMigrationApiController;
import io.airbyte.server.apis.DestinationApiController;
import io.airbyte.server.apis.DestinationDefinitionApiController;
import io.airbyte.server.apis.DestinationDefinitionSpecificationApiController;
import io.airbyte.server.apis.HealthApiController;
import io.airbyte.server.apis.binders.AttemptApiBinder;
import io.airbyte.server.apis.binders.ConnectionApiBinder;
import io.airbyte.server.apis.binders.DbMigrationBinder;
import io.airbyte.server.apis.binders.DestinationApiBinder;
import io.airbyte.server.apis.binders.DestinationDefinitionApiBinder;
import io.airbyte.server.apis.binders.DestinationDefinitionSpecificationApiBinder;
import io.airbyte.server.apis.binders.HealthApiBinder;
import io.airbyte.server.apis.factories.AttemptApiFactory;
import io.airbyte.server.apis.factories.ConnectionApiFactory;
import io.airbyte.server.apis.factories.DbMigrationApiFactory;
import io.airbyte.server.apis.factories.DestinationApiFactory;
import io.airbyte.server.apis.factories.DestinationDefinitionApiFactory;
import io.airbyte.server.apis.factories.DestinationDefinitionSpecificationApiFactory;
import io.airbyte.server.apis.factories.HealthApiFactory;
import io.airbyte.server.handlers.AttemptHandler;
import io.airbyte.server.handlers.ConnectionsHandler;
import io.airbyte.server.handlers.DbMigrationHandler;
import io.airbyte.server.handlers.DestinationDefinitionsHandler;
import io.airbyte.server.handlers.DestinationHandler;
import io.airbyte.server.handlers.HealthCheckHandler;
import io.airbyte.server.handlers.OperationsHandler;
import io.airbyte.server.handlers.SchedulerHandler;
import io.airbyte.server.scheduler.EventRunner;
Expand Down Expand Up @@ -58,7 +73,10 @@ ServerRunnable create(final SynchronousSchedulerClient synchronousSchedulerClien
final Flyway jobsFlyway,
final AttemptHandler attemptHandler,
final ConnectionsHandler connectionsHandler,
final DbMigrationHandler dbMigrationHandler,
final DestinationDefinitionsHandler destinationDefinitionsHandler,
final DestinationHandler destinationApiHandler,
final HealthCheckHandler healthCheckHandler,
final OperationsHandler operationsHandler,
final SchedulerHandler schedulerHandler);

Expand All @@ -83,7 +101,10 @@ public ServerRunnable create(final SynchronousSchedulerClient synchronousSchedul
final Flyway jobsFlyway,
final AttemptHandler attemptHandler,
final ConnectionsHandler connectionsHandler,
final DbMigrationHandler dbMigrationHandler,
final DestinationDefinitionsHandler destinationDefinitionsHandler,
final DestinationHandler destinationApiHandler,
final HealthCheckHandler healthCheckHandler,
final OperationsHandler operationsHandler,
final SchedulerHandler schedulerHandler) {
final Map<String, String> mdc = MDC.getCopyOfContextMap();
Expand Down Expand Up @@ -117,13 +138,37 @@ public ServerRunnable create(final SynchronousSchedulerClient synchronousSchedul
schedulerHandler,
mdc);

DbMigrationApiFactory.setValues(dbMigrationHandler, mdc);

DestinationApiFactory.setValues(destinationApiHandler, schedulerHandler, mdc);

DestinationDefinitionApiFactory.setValues(destinationDefinitionsHandler);

DestinationDefinitionSpecificationApiFactory.setValues(schedulerHandler);

HealthApiFactory.setValues(healthCheckHandler);

// server configurations
final Set<Class<?>> componentClasses = Set.of(ConfigurationApi.class, AttemptApiController.class, ConnectionApiController.class,
DestinationApiController.class);
final Set<Object> components = Set.of(new CorsFilter(), new ConfigurationApiBinder(), new AttemptApiBinder(), new ConnectionApiBinder(),
new DestinationApiBinder());
final Set<Class<?>> componentClasses = Set.of(
ConfigurationApi.class,
AttemptApiController.class,
ConnectionApiController.class,
DbMigrationApiController.class,
DestinationApiController.class,
DestinationDefinitionApiController.class,
DestinationDefinitionSpecificationApiController.class,
HealthApiController.class);

final Set<Object> components = Set.of(
new CorsFilter(),
new ConfigurationApiBinder(),
new AttemptApiBinder(),
new ConnectionApiBinder(),
new DbMigrationBinder(),
new DestinationApiBinder(),
new DestinationDefinitionApiBinder(),
new DestinationDefinitionSpecificationApiBinder(),
new HealthApiBinder());

// construct server
return new ServerApp(airbyteVersion, componentClasses, components);
Expand Down
Loading