Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: SurveySparrow [low-code cdk] #18395

Merged
merged 13 commits into from
Nov 3, 2022

Conversation

jj-nilbodee
Copy link
Contributor

@jj-nilbodee jj-nilbodee commented Oct 24, 2022

What

Adding new source from SurveySparrow

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Screenshot 2022-10-24 at 8 39 22 pm

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 24, 2022
@marcosmarxm
Copy link
Member

Thanks for the contribution! Someone will review it during this week. If you have any questions please create comments so the reviewer can focus on those points.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, look good!

@jj-nilbodee jj-nilbodee requested review from marcosmarxm and girarda and removed request for marcosmarxm October 25, 2022 14:55
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments until we get the StreamSlicer working :)

@jj-nilbodee jj-nilbodee requested review from marcosmarxm and removed request for girarda October 28, 2022 21:58
@jj-nilbodee
Copy link
Contributor Author

I have resolved all comments and bumping the cdk version in requirements to ~=0.4
Here's the acceptance test result from the latest changes. Lmk if you need anything else

Screenshot 2022-10-28 at 10 57 00 pm

@RealChrisSean
Copy link

@marcosmarxm
Copy link
Member

Thanks @jhajajaas I'll review today again.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jhajajaas I'll publish the connector later.

@marcosmarxm
Copy link
Member

marcosmarxm commented Nov 3, 2022

/test connector=connectors/source-survey-sparrow

🕑 connectors/source-survey-sparrow https://github.com/airbytehq/airbyte/actions/runs/3388244079
❌ connectors/source-survey-sparrow https://github.com/airbytehq/airbyte/actions/runs/3388244079
🐛 https://gradle.com/s/fykg72jnqfyig

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
============ 1 failed, 23 passed, 3 skipped, 27 warnings in 28.41s =============

@marcosmarxm
Copy link
Member

marcosmarxm commented Nov 3, 2022

/test connector=connectors/source-survey-sparrow

🕑 connectors/source-survey-sparrow https://github.com/airbytehq/airbyte/actions/runs/3388605086
✅ connectors/source-survey-sparrow https://github.com/airbytehq/airbyte/actions/runs/3388605086
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     97    51%   35, 41-43, 48, 54, 60, 66, 72-74, 80-95, 100, 105-107, 113-115, 121-122, 127-128, 133, 139, 148-157, 163-168, 232, 238, 244-250, 258-263, 271-284, 289-295, 302-313, 320-336
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              329    106    68%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 447-455, 484-485, 491, 494, 530-540, 553-578
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1479    376    75%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
================= 24 passed, 3 skipped, 27 warnings in 26.39s ==================

@marcosmarxm
Copy link
Member

marcosmarxm commented Nov 3, 2022

/publish connector=connectors/source-survey-sparrow

🕑 Publishing the following connectors:
connectors/source-survey-sparrow
https://github.com/airbytehq/airbyte/actions/runs/3388686740


Connector Did it publish? Were definitions generated?
connectors/source-survey-sparrow

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@marcosmarxm marcosmarxm merged commit c40f1b6 into airbytehq:master Nov 3, 2022
@jj-nilbodee jj-nilbodee deleted the source-surveysparrow branch November 6, 2022 23:04
@marcosmarxm marcosmarxm changed the title 🎉 New Source: SurveySparrow 🎉 New Source: SurveySparrow [low-code cdk] Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants