-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: SurveySparrow [low-code cdk] #18395
🎉 New Source: SurveySparrow [low-code cdk] #18395
Conversation
Thanks for the contribution! Someone will review it during this week. If you have any questions please create comments so the reviewer can focus on those points. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, look good!
airbyte-integrations/connectors/source-survey-sparrow/integration_tests/catalog.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-survey-sparrow/source_survey_sparrow/schemas/TODO.md
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-survey-sparrow/source_survey_sparrow/spec.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-survey-sparrow/source_survey_sparrow/survey_sparrow.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-survey-sparrow/source_survey_sparrow/survey_sparrow.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments until we get the StreamSlicer working :)
airbyte-integrations/connectors/source-survey-sparrow/source_survey_sparrow/survey_sparrow.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-survey-sparrow/source_survey_sparrow/survey_sparrow.yaml
Outdated
Show resolved
Hide resolved
Thanks @jhajajaas I'll review today again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @jhajajaas I'll publish the connector later.
/test connector=connectors/source-survey-sparrow
Build FailedTest summary info:
|
1d52639
to
4237a17
Compare
/test connector=connectors/source-survey-sparrow
Build PassedTest summary info:
|
/publish connector=connectors/source-survey-sparrow
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
Adding new source from SurveySparrow
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.