Add initial acceptance test structure and first test #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
michel-tricot
approved these changes
Sep 1, 2020
dataline-acceptance-tests/src/accTest/java/io/dataline/tests/acceptance/AcceptanceTests.java
Outdated
Show resolved
Hide resolved
| .workspaceId(defaultWorkspaceId) | ||
| .connectionConfiguration(dbConfiguration); | ||
|
|
||
| SourceImplementationRead createResponse = callApi("source_implementations/create", sourceImplementationCreate, SourceImplementationRead.class); |
There was a problem hiding this comment.
I wonder if we could generate a client from the oas definition. that will also help catch name changes if they happen
There was a problem hiding this comment.
Will look into this
There was a problem hiding this comment.
This hasn't been 100% straightforward, going to do this in a following PR so Jared can work off of this module
| testImplementation "org.testcontainers:testcontainers:1.14.3" | ||
| testImplementation "org.testcontainers:postgresql:1.14.3" | ||
| testImplementation "org.postgresql:postgresql:42.2.16" |
There was a problem hiding this comment.
isn't it better when it is sorted?
There was a problem hiding this comment.
is there a plugin that will sort this?
There was a problem hiding this comment.
Found this. Might toy around with it but generally I don't find myself spending any meaningful time reorganizing deps
dataline-acceptance-tests/src/accTest/java/io/dataline/tests/acceptance/AcceptanceTests.java
Outdated
Show resolved
Hide resolved
jrhizor
approved these changes
Sep 1, 2020
Co-authored-by: Michel Tricot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
dataline-acceptance-testsgradle subproject. This module's tests are run only when explicitly requested, and not as part of the main build.Recommended reading order
dataline-acceptance-tests/build.gradletools/bin/build.sh.gradle.ymlAcceptanceTests.java