-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental CSV destination #1294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
short and sweet. 👌
one question that is blocking but once we resolve, will approve. good stuff.
...rs/destination-csv/src/main/java/io/airbyte/integrations/destination/csv/CsvDestination.java
Outdated
Show resolved
Hide resolved
I am a bit nervous about appending to a file. |
With @cgardens's suggestions, we are not appending to a file anymore but we'll always overwrite the final file as a single file (not a folder with multiple partitioned files in it) I think this consideration can be tackled once this destination is able to actually write in GCS/S3? (plus the source-file can read only one file at a time at the moment!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
What
see #1239