Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect sync mode regardless of input state in mailchimp #1213

Merged
merged 5 commits into from
Dec 11, 2020
Merged

Respect sync mode regardless of input state in mailchimp #1213

merged 5 commits into from
Dec 11, 2020

Conversation

sherifnada
Copy link
Contributor

No description provided.

@sherifnada
Copy link
Contributor Author

sherifnada commented Dec 5, 2020 •
edited by github-actions bot
Loading

/test connector=source-mailchimp

🕑 source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/401874113
❌ source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/401874113

sherifnada
sherifnada commented Dec 5, 2020
View reviewed changes
airbyte-integrations/connectors/source-mailchimp/source_mailchimp/source.py
entity_map = {
"Lists": client.lists,
"Campaigns": client.campaigns,
}

for record in entity_map[stream](state=state):
stream_name = configured_stream.stream.name
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the only change really needed

@sherifnada sherifnada requested a review from cgardens December 5, 2020 01:19
@sherifnada
Copy link
Contributor Author

sherifnada commented Dec 5, 2020 •
edited by github-actions bot
Loading

/test connector=source-mailchimp

🕑 source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/401907299
✅ source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/401907299

cgardens
cgardens approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@cgardens cgardens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgardens
Copy link
Contributor

cgardens commented Dec 10, 2020 •
edited
Loading

should we add a test to the StandardTests to catch this case? Can happen separately. If you think it is worth doing would you mind creating an issue for it and putting it into the next sprint? maybe tricky with the current iface, but it would be good track it i think.

@sherifnada sherifnada merged commit 93674f6 into master Dec 11, 2020
@sherifnada sherifnada deleted the sherif/incremental-chimp branch December 11, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor approved these changes

@cgardens cgardens cgardens approved these changes

@ChristopheDuong ChristopheDuong Awaiting requested review from ChristopheDuong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sherifnada @cgardens @jrhizor