Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source zoho-crm: remove nullable field #11841

Closed
wants to merge 2 commits into from
Closed

🐛 Source zoho-crm: remove nullable field #11841

wants to merge 2 commits into from
+20 −10

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Apr 8, 2022 •
edited
Loading

What

octavia-cli does not expect an array in the type fields.
This connector uses an array in the type field for the start_datetime field.
It makes octavia integration test fail and octavia won't work to generate config for this connector.

How

Change ["null", "string"] to string.

@github-actions github-actions bot added the area/connectors Connector related issues label Apr 8, 2022
@alafanechere alafanechere temporarily deployed to more-secrets April 8, 2022 18:49 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets April 8, 2022 18:49 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Apr 8, 2022
@alafanechere alafanechere marked this pull request as ready for review April 8, 2022 19:10
@alafanechere alafanechere temporarily deployed to more-secrets April 8, 2022 19:10 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets April 8, 2022 19:10 Inactive
@alafanechere
Copy link
Contributor Author

alafanechere commented Apr 8, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/2117081751
❌ Failed to publish connectors/source-zoho-crm
❌ Couldn't auto-bump version for connectors/source-zoho-crm

@timroes timroes mentioned this pull request Apr 8, 2022
Closed
@alafanechere
Copy link
Contributor Author

alafanechere commented Apr 8, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-zoho-crm

🕑 connectors/source-zoho-crm https://github.com/airbytehq/airbyte/actions/runs/2117305273
❌ Failed to publish connectors/source-zoho-crm
❌ Couldn't auto-bump version for connectors/source-zoho-crm

@swyxio swyxio deleted the augustin/source-zoho-crm-type-fix branch October 12, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alafanechere