Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source-postgres: fixed roles for fetching materialized view processing #11798

Conversation

etsybaev
Copy link
Contributor

@etsybaev etsybaev commented Apr 7, 2022

What

Not all Materialized views are visible now

How

Fixed roles check for Materialized views processing

🚨 User Impact 🚨

No breaking changes expected

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added the area/connectors Connector related issues label Apr 7, 2022
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etsybaev
Copy link
Contributor Author

etsybaev commented Apr 8, 2022

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2113663163
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2113663163
No Python unittests run

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Apr 8, 2022
@etsybaev etsybaev temporarily deployed to more-secrets April 8, 2022 08:41 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets April 8, 2022 08:41 Inactive
@alexandr-shegeda
Copy link
Contributor

we can proceed with publishing and merging without airbyte review

@etsybaev
Copy link
Contributor Author

etsybaev commented Apr 8, 2022

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2114176294
❌ Failed to publish connectors/source-postgres
❌ Couldn't auto-bump version for connectors/source-postgres
🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2114176294
❌ Failed to publish connectors/source-postgres
❌ Couldn't auto-bump version for connectors/source-postgres

@etsybaev etsybaev temporarily deployed to more-secrets April 8, 2022 12:09 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets April 8, 2022 12:09 Inactive
@etsybaev etsybaev marked this pull request as ready for review April 8, 2022 12:10
@etsybaev etsybaev changed the title Source-postgres: fixed roles for fetching materialized view processing 🎉Source-postgres: fixed roles for fetching materialized view processing Apr 8, 2022
@etsybaev
Copy link
Contributor Author

etsybaev commented Apr 8, 2022

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2115117437
🚀 Successfully published connectors/source-postgres
🚀 Auto-bumped version for connectors/source-postgres
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2115117437

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 8, 2022 14:02 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 8, 2022 14:02 Inactive
@etsybaev etsybaev merged commit d84df02 into master Apr 8, 2022
@etsybaev etsybaev deleted the etsybaev/10389-source-postgres-fix-roles-for-materialized-view branch April 8, 2022 17:05
@etsybaev etsybaev temporarily deployed to more-secrets April 8, 2022 17:06 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets April 8, 2022 17:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres Source Connector doesn't correctly read privileges for materialized views
3 participants