Fix pre-commit hook failing because of black #11737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alafanechere
approved these changes
Apr 5, 2022
Co-authored-by: Augustin <[email protected]>
supertopher
reviewed
Apr 5, 2022
| @@ -7,8 +7,8 @@ repos: | |||
| hooks: | |||
| - id: licenseheaders | |||
| args: ["--tmpl=LICENSE_SHORT", "--ext=py", "-f"] | |||
| - repo: https://github.com/ambv/black | |||
| rev: 22.1.0 | |||
| - repo: https://github.com/psf/black | |||
There was a problem hiding this comment.
I have no context and am just curious: why did we switch maintainers? A quick look at both GitHub pages didn't give me a clear answer
There was a problem hiding this comment.
https://github.com/ambv/black is now redirecting to https://github.com/psf/black so it's not an actual maintainer switch, arguably unnecessary but just for clarity.
There was a problem hiding this comment.
Cool. Cool cool cool. thanks for the context
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
See this issue and this PR.
I've just updated the black version in the pre-commit hook to match the upgrade done there.