-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish connector command now auto bumps version #11712
Conversation
test
|
testing with auto-bump flag true
|
@@ -42,7 +42,7 @@ | |||
- name: Apify Dataset | |||
sourceDefinitionId: 47f17145-fe20-4ef5-a548-e29b048adf84 | |||
dockerRepository: airbyte/source-apify-dataset | |||
dockerImageTag: 0.1.3 | |||
dockerImageTag: 0.1.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these be reverted before we merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been publishing the version bumps while testing, do you think it's worth reverting and removing the published bumps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah should we just add that info in the changelog just so we know what these versions are?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes good point, will add that
What
solving #11564
How
./gradlew :airbyte-config:init:processResources
generate seed specsNotes
The version bumps to destination-dev-null and source-apify-dataset were just dummy bumps to test the publish changes.
I played around with automatically bumping the changelog in the connector's docs but decided against it because: