Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable shopify transaction syncing #1120

Merged
merged 5 commits into from
Dec 7, 2020
Merged

re-enable shopify transaction syncing #1120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4d90a5e
enable shopify transactions
jrhizor Nov 30, 2020
fffbeb5
fully revert
jrhizor Nov 30, 2020
48c0449
remove unused import
jrhizor Nov 30, 2020
856eff9
Merge branch 'master' into jrhizor/enable-shopify-transactions
jrhizor Dec 7, 2020
5418981
bump version to 0.1.5
jrhizor Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ain/resources/config/STANDARD_SOURCE_DEFINITION/b1892b11-788d-44bd-b9ec-3a436f7b54ce.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"sourceDefinitionId": "b1892b11-788d-44bd-b9ec-3a436f7b54ce",
"name": "Shopify",
"dockerRepository": "airbyte/source-shopify-singer",
"dockerImageTag": "0.1.4",
"dockerImageTag": "0.1.5",
"documentationUrl": "https://hub.docker.com/r/airbyte/source-shopify-singer"
}
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
- sourceDefinitionId: b1892b11-788d-44bd-b9ec-3a436f7b54ce
name: Shopify
dockerRepository: airbyte/source-shopify-singer
dockerImageTag: 0.1.4
dockerImageTag: 0.1.5
documentationUrl: https://hub.docker.com/r/airbyte/source-shopify-singer
- sourceDefinitionId: 9845d17a-45f1-4070-8a60-50914b1c8e2b
name: HTTP Request
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-shopify-singer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ RUN pip install pip==20.3
RUN pip install tap-shopify==1.2.6
RUN pip install ".[main]"

LABEL io.airbyte.version=0.1.4
LABEL io.airbyte.version=0.1.5
LABEL io.airbyte.name=airbyte/source-shopify-singer
14 changes: 1 addition & 13 deletions airbyte-integrations/connectors/source-shopify-singer/source_shopify_singer/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"""

import shopify
from airbyte_protocol import AirbyteCatalog, AirbyteConnectionStatus, Status
from airbyte_protocol import AirbyteConnectionStatus, Status
from base_python import AirbyteLogger, ConfigContainer
from base_singer import SingerSource

Expand Down Expand Up @@ -57,18 +57,6 @@ def check(self, logger: AirbyteLogger, config_container: ConfigContainer) -> Air
status=Status.FAILED, message="Unable to connect to the Shopify API with the provided credentials."
)

def discover(self, logger: AirbyteLogger, config_container: ConfigContainer) -> AirbyteCatalog:
catalog = super().discover(logger, config_container)

filtered_streams = []
for stream in catalog.streams:
if stream.name == "transactions":
continue
filtered_streams.append(stream)

catalog.streams = filtered_streams
return catalog

def discover_cmd(self, logger: AirbyteLogger, config_path: str) -> str:
return f"{TAP_CMD} -c {config_path} --discover"

Expand Down