Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 SAT: Fix test_oneof_usage fail #9860

Closed
keu opened this issue Jan 28, 2022 · 0 comments · Fixed by #9861
Closed

🐛 SAT: Fix test_oneof_usage fail #9860

keu opened this issue Jan 28, 2022 · 0 comments · Fixed by #9861
Assignees
@keu
Labels
needs-triage type/bug Something isn't working

Comments

@keu
Copy link
Contributor

keu commented Jan 28, 2022

From the slack conv:
https://airbytehq.slack.com/archives/C02URF2BKL1/p1643341400367279

Tell us what happens.
After release of #9768 test_oneof_usage is failing with error:

       for variant_path in variant_paths:
>           top_level_obj = dpath.util.get(self._schema, "/".join(variant_path[:-1]))
E           AttributeError: 'TestSpec' object has no attribute '_schema'

Expected Behavior

test_oneof_usage shouldn't crash the test execution
@keu keu added type/bug Something isn't working needs-triage labels Jan 28, 2022
@keu keu self-assigned this Jan 28, 2022
@keu keu linked a pull request Jan 28, 2022 that will close this issue
🐛 SAT: Fix test_oneof_usage fail #9860 #9861
Merged
@keu keu closed this as completed in #9861 Jan 28, 2022
keu added a commit that referenced this issue Jan 28, 2022
@keu @eugene-kulak
🐛 SAT: Fix test_oneof_usage fail #9860 (#9861)
d566369 
* fix pre-commit config

* fix tests

* beatify CHANGELOG.md

Co-authored-by: Eugene Kulak <[email protected]>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keu keu

Labels
needs-triage type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 SAT: Fix test_oneof_usage fail #9860 airbytehq/airbyte
1 participant
@keu