CDK: Refactor JSONSchemaResolver
and ResourceSchemaLoader
for better testing
#3222
Labels
accepting-contributions
Feel free to contribute to them
CDK
Connector Development Kit
type/enhancement
New feature or request
Milestone
Tell us about the problem you're trying to solve
There is a number of improvements that can be made to classes in
airbyte_cdk/schema_helpers.py
.First,
JsonSchemaResolver
can be refactored to have the following signature:Then
ResourceSchemaLoader
would be responsible just for finding the right files in the package directory and passing them intoJsonSchemaResolver
. We can even change the signature for RSL to be:this would allow us to mock JsonSchemaResolver and instead just validate that given the right file structure, RSL is passing the correct files to JSR.
┆Issue is synchronized with this Asana task by Unito
The text was updated successfully, but these errors were encountered: