✨ feat(source-bing-ads): support PerformanceMax Campaign Type (#40746)

Co-authored-by: Matthew Belair <[email protected]> Co-authored-by: Matthew Bélair <[email protected]>
airbytehq · Jul 5, 2024 · ba4b26d · ba4b26d
1 parent 4e91464
commit ba4b26d
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 5 deletions.
diff --git a/airbyte-integrations/connectors/source-bing-ads/metadata.yaml b/airbyte-integrations/connectors/source-bing-ads/metadata.yaml
@@ -16,7 +16,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: 47f25999-dd5e-4636-8c39-e7cea2453331
-  dockerImageTag: 2.6.5
+  dockerImageTag: 2.6.6
   dockerRepository: airbyte/source-bing-ads
   documentationUrl: https://docs.airbyte.com/integrations/sources/bing-ads
   githubIssueLabel: source-bing-ads

diff --git a/airbyte-integrations/connectors/source-bing-ads/pyproject.toml b/airbyte-integrations/connectors/source-bing-ads/pyproject.toml
@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
 build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
-version = "2.6.5"
+version = "2.6.6"
 name = "source-bing-ads"
 description = "Source implementation for Bing Ads."
 authors = [ "Airbyte <[email protected]>",]

diff --git a/airbyte-integrations/connectors/source-bing-ads/source_bing_ads/base_streams.py b/airbyte-integrations/connectors/source-bing-ads/source_bing_ads/base_streams.py
@@ -248,7 +248,7 @@ class Campaigns(BingAdsCampaignManagementStream):
         "TargetSetting",
         "VerifiedTrackingSetting",
     ]
-    campaign_types: Iterable[str] = ["Audience", "DynamicSearchAds", "Search", "Shopping"]
+    campaign_types: Iterable[str] = ["Audience", "DynamicSearchAds", "Search", "Shopping", "PerformanceMax"]
 
     parent_key_to_foreign_key_map = {
         "AccountId": "account_id",

diff --git a/airbyte-integrations/connectors/source-bing-ads/unit_tests/test_source.py b/airbyte-integrations/connectors/source-bing-ads/unit_tests/test_source.py
@@ -103,7 +103,7 @@ def test_campaigns_request_params(mocked_client, config):
     request_params = campaigns.request_params(stream_slice={"account_id": "account_id"})
     assert request_params == {
         "AccountId": "account_id",
-        "CampaignType": "Audience DynamicSearchAds Search Shopping",
+        "CampaignType": "Audience DynamicSearchAds Search Shopping PerformanceMax",
         "ReturnAdditionalFields": "AdScheduleUseSearcherTimeZone BidStrategyId CpvCpmBiddingScheme DynamicDescriptionSetting DynamicFeedSetting MaxConversionValueBiddingScheme MultimediaAdsBidAdjustment TargetImpressionShareBiddingScheme TargetSetting VerifiedTrackingSetting",
     }
 
@@ -176,7 +176,16 @@ def test_ads_stream_slices(mocked_client, config):
 @pytest.mark.parametrize(
     ("stream", "stream_slice"),
     (
-        (Accounts, {"predicates": {"Predicate": [{"Field": "UserId", "Operator": "Equals", "Value": "131313131"},]}}),
+        (
+            Accounts,
+            {
+                "predicates": {
+                    "Predicate": [
+                        {"Field": "UserId", "Operator": "Equals", "Value": "131313131"},
+                    ]
+                }
+            },
+        ),
         (AdGroups, {"campaign_id": "campaign_id"}),
         (Ads, {"ad_group_id": "ad_group_id"}),
         (Campaigns, {"account_id": "account_id"}),

diff --git a/docs/integrations/sources/bing-ads.md b/docs/integrations/sources/bing-ads.md
@@ -258,6 +258,7 @@ The Bing Ads API limits the number of requests for all Microsoft Advertising cli
 
 | Version | Date       | Pull Request                                                                                                                     | Subject                                                                                                                                        |
 | :------ | :--------- | :------------------------------------------------------------------------------------------------------------------------------- | :--------------------------------------------------------------------------------------------------------------------------------------------- |
+| 2.6.6 | 2024-07-05 | [34966](https://github.com/airbytehq/airbyte/pull/34966) | Add support for Performance Max campaigns. |
 | 2.6.5 | 2024-06-27 | [40585](https://github.com/airbytehq/airbyte/pull/40585) | Replaced deprecated AirbyteLogger with logging.Logger |
 | 2.6.4 | 2024-06-25 | [40457](https://github.com/airbytehq/airbyte/pull/40457) | Update dependencies |
 | 2.6.3 | 2024-06-22 | [40006](https://github.com/airbytehq/airbyte/pull/40006) | Update dependencies |