Cleanup alt attributes on images (#19000)

airbytehq · Nov 7, 2022 · 91bb1bf · 91bb1bf
1 parent 41a12f6
commit 91bb1bf
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 19 deletions.
diff --git a/airbyte-webapp/public/index.html b/airbyte-webapp/public/index.html
@@ -17,7 +17,7 @@
   </head>
   <body>
     <noscript>
-      <img src="%PUBLIC_URL%/logo.png" alt="logo" width="90" height="94"/>
+      <img src="%PUBLIC_URL%/logo.png" alt="" width="90" height="94"/>
       <div class="card">
         You need to enable JavaScript to run this app.
       </div>

diff --git a/airbyte-webapp/src/components/Placeholder/Placeholder.tsx b/airbyte-webapp/src/components/Placeholder/Placeholder.tsx
@@ -16,7 +16,7 @@ const Img = styled.img<PlaceholderProps>`
 `;
 
 const Placeholder: React.FC<PlaceholderProps> = ({ resource }) => {
-  return <Img src={`/empty-${resource}.png`} alt="placeholder" resource={resource} />;
+  return <Img src={`/empty-${resource}.png`} alt="" resource={resource} />;
 };
 
 export default Placeholder;
diff --git a/airbyte-webapp/src/components/common/EmptyResourceBlock/EmptyResourceBlock.tsx b/airbyte-webapp/src/components/common/EmptyResourceBlock/EmptyResourceBlock.tsx
@@ -10,7 +10,7 @@ interface EmptyResourceBlockProps {
 export const EmptyResourceBlock: React.FC<EmptyResourceBlockProps> = ({ text, description }) => (
   <div className={styles.content}>
     <div className={styles.imgBlock}>
-      <img src="/cactus.png" height={40} alt="cactus" />
+      <img src="/cactus.png" height={40} alt="" />
     </div>
     {text}
     <div className={styles.description}>{description}</div>

diff --git a/airbyte-webapp/src/packages/cloud/views/workspaces/WorkspacesPage/WorkspacesPage.tsx b/airbyte-webapp/src/packages/cloud/views/workspaces/WorkspacesPage/WorkspacesPage.tsx
@@ -14,7 +14,7 @@ const WorkspacesPage: React.FC = () => {
 
   return (
     <div className={styles.container}>
-      <img className={styles.logo} alt="logo" src="/cloud-main-logo.svg" width={186} />
+      <img className={styles.logo} alt="" src="/cloud-main-logo.svg" width={186} />
       <Heading as="h1" size="lg" centered>
         <FormattedMessage id="workspaces.title" />
       </Heading>

diff --git a/airbyte-webapp/src/pages/OnboardingPage/components/LetterLine.tsx b/airbyte-webapp/src/pages/OnboardingPage/components/LetterLine.tsx
@@ -69,7 +69,7 @@ const LetterLine: React.FC<LetterLineProps> = ({ onRight, exit }) => {
   return (
     <Line $onRight={onRight}>
       <Path exit={exit} />
-      <Img src="/newsletter.png" alt="newsletter" width={78} height={68} exit={exit} />
+      <Img src="/newsletter.png" alt="" width={78} height={68} exit={exit} />
     </Line>
   );
 };

diff --git a/airbyte-webapp/src/pages/SettingsPage/pages/NotificationPage/components/WebHookForm.tsx b/airbyte-webapp/src/pages/SettingsPage/pages/NotificationPage/components/WebHookForm.tsx
@@ -155,13 +155,7 @@ export const WebHookForm: React.FC<WebHookFormProps> = ({ webhook }) => {
                     </a>
                   </li>
                 </ul>
-                <img
-                  className={styles.webhookGuideImg}
-                  alt={formatMessage({
-                    id: "settings.notificationGuide.button",
-                  })}
-                  src={help}
-                />
+                <img className={styles.webhookGuideImg} alt="" src={help} />
               </div>
               <Row className={styles.webhookUrlLabelRow}>
                 <Cell className={styles.webhookUrlLabelCell}>
@@ -180,13 +174,7 @@ export const WebHookForm: React.FC<WebHookFormProps> = ({ webhook }) => {
                       >
                         <FormattedMessage id="settings.notificationGuide.button" />
                       </Button>
-                      <img
-                        className={styles.webhookGuideButtonImg}
-                        alt={formatMessage({
-                          id: "settings.notificationGuide.button",
-                        })}
-                        src={help}
-                      />
+                      <img className={styles.webhookGuideButtonImg} alt="" src={help} />
                     </>
                   )}
                 </Cell>