fix disablings

airbytehq · Dec 19, 2024 · 90deb5f · 90deb5f
1 parent 9628dc9
commit 90deb5f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 40 deletions.
diff --git a/...kotlin/io/airbyte/cdk/load/mock_integration_test/MockBasicFunctionalityIntegrationTest.kt b/...kotlin/io/airbyte/cdk/load/mock_integration_test/MockBasicFunctionalityIntegrationTest.kt
@@ -9,7 +9,6 @@ import io.airbyte.cdk.load.test.util.NoopExpectedRecordMapper
 import io.airbyte.cdk.load.test.util.NoopNameMapper
 import io.airbyte.cdk.load.write.BasicFunctionalityIntegrationTest
 import io.airbyte.cdk.load.write.Untyped
-import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.api.Test
 
 class MockBasicFunctionalityIntegrationTest :
@@ -93,6 +92,4 @@ class MockBasicFunctionalityIntegrationTest :
     override fun testBasicTypes() {
         super.testBasicTypes()
     }
-
-    @Test @Disabled override fun testBasicWriteFile() {}
 }
diff --git a/...t/src/main/kotlin/io/airbyte/cdk/load/data/iceberg/parquet/SchemalessTypesToStringType.kt b/...t/src/main/kotlin/io/airbyte/cdk/load/data/iceberg/parquet/SchemalessTypesToStringType.kt
@@ -1,3 +1,7 @@
+/*
+ * Copyright (c) 2024 Airbyte, Inc., all rights reserved.
+ */
+
 package io.airbyte.cdk.load.data.iceberg.parquet
 
 import io.airbyte.cdk.load.data.AirbyteSchemaIdentityMapper
@@ -7,7 +11,7 @@ import io.airbyte.cdk.load.data.ObjectTypeWithoutSchema
 import io.airbyte.cdk.load.data.StringType
 import io.airbyte.cdk.load.data.UnknownType
 
-class SchemalessTypesToStringType: AirbyteSchemaIdentityMapper {
+class SchemalessTypesToStringType : AirbyteSchemaIdentityMapper {
     override fun mapArrayWithoutSchema(schema: ArrayTypeWithoutSchema) = StringType
     override fun mapObjectWithEmptySchema(schema: ObjectTypeWithEmptySchema) = StringType
     override fun mapObjectWithoutSchema(schema: ObjectTypeWithoutSchema) = StringType

diff --git a/...t-integration/kotlin/io/airbyte/integrations/destination/iceberg/v2/IcebergV2WriteTest.kt b/...t-integration/kotlin/io/airbyte/integrations/destination/iceberg/v2/IcebergV2WriteTest.kt
@@ -42,15 +42,7 @@ abstract class IcebergV2WriteTest(
     ) {
     @Test
     @Disabled(
-        "Expected because we seem to be mapping timestamps to long when we should be mapping them to an OffsetDateTime"
-    )
-    override fun testBasicTypes() {
-        super.testBasicTypes()
-    }
-
-    @Test
-    @Disabled(
-        "Expected because we seem to be mapping timestamps to long when we should be mapping them to an OffsetDateTime"
+        "This is currently hanging forever and we should look into why https://github.com/airbytehq/airbyte-internal-issues/issues/11162"
     )
     override fun testInterruptedTruncateWithPriorData() {
         super.testInterruptedTruncateWithPriorData()
@@ -63,30 +55,16 @@ abstract class IcebergV2WriteTest(
     }
 
     @Test
-    //    @Disabled
-    override fun testContainerTypes() {
-        super.testContainerTypes()
-    }
-
-    @Test
-    @Disabled(
-        "Expected because we seem to be mapping timestamps to long when we should be mapping them to an OffsetDateTime"
-    )
+    @Disabled("This is currently hanging forever and we should look into why")
     override fun resumeAfterCancelledTruncate() {
         super.resumeAfterCancelledTruncate()
     }
 
     @Test
-    @Disabled("This is expected")
+    @Disabled("This is expected (dest-iceberg-v2 doesn't yet support schema evolution)")
     override fun testAppendSchemaEvolution() {
         super.testAppendSchemaEvolution()
     }
-
-    @Test
-    //    @Disabled
-    override fun testUnions() {
-        super.testUnions()
-    }
 }
 
 class IcebergGlueWriteTest :
@@ -97,17 +75,7 @@ class IcebergGlueWriteTest :
                 IcebergV2TestUtil.parseConfig(IcebergV2TestUtil.GLUE_CONFIG_PATH)
             )
         ),
-    ) {
-    @Test
-    override fun testContainerTypes() {
-        super.testContainerTypes()
-    }
-
-    @Test
-    override fun testUnions() {
-        super.testUnions()
-    }
-}
+    )
 
 @Disabled(
     "This is currently disabled until we are able to make it run via airbyte-ci. It works as expected locally"