Skip to content

Commit

Permalink
Add section about user impact to PR template (#8003)
Browse files Browse the repository at this point in the history
Co-authored-by: LiRen Tu <[email protected]>
  • Loading branch information
sherifnada and tuliren authored Nov 16, 2021
1 parent c99335f commit 90a5dfb
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,16 @@
1. `x.java`
2. `y.python`

## 🚨 User Impact 🚨
Are there any breaking changes? If yes, please make sure to include it here and in any changelogs with the 🚨🚨 emoji
What is the end result perceived by the user?

## Pre-merge Checklist
Expand the relevant checklist and delete the others.

<details><summary> <strong> New Connector </strong></summary>
<p>

#### Community member or Airbyter

- [ ] **Community member?** Grant edit access to maintainers ([instructions](https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests))
Expand Down

0 comments on commit 90a5dfb

Please sign in to comment.