#985 source salesforce: move SATs to high level strictness

airbytehq · Nov 15, 2022 · 3daa7ef · 3daa7ef
1 parent ce26778
commit 3daa7ef
Show file tree

Hide file tree

Showing 4 changed files with 235 additions and 24 deletions.
diff --git a/airbyte-integrations/connectors/source-salesforce/acceptance-test-config.yml b/airbyte-integrations/connectors/source-salesforce/acceptance-test-config.yml
@@ -1,25 +1,43 @@
 # See [Source Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/source-acceptance-tests-reference)
 # for more information about how to configure these tests
 connector_image: airbyte/source-salesforce:dev
-tests:
+test_strictness_level: high
+acceptance_tests:
   spec:
-    - spec_path: "source_salesforce/spec.yaml"
+    tests:
+      - spec_path: "source_salesforce/spec.yaml"
   connection:
-    - config_path: "secrets/config.json"
-      status: "succeed"
-    - config_path: "secrets/config_sandbox.json"
-      status: "succeed"
-    - config_path: "integration_tests/invalid_config.json"
-      status: "failed"
+    tests:
+      - config_path: "secrets/config.json"
+        status: "succeed"
+      - config_path: "secrets/config_sandbox.json"
+        status: "succeed"
+      - config_path: "integration_tests/invalid_config.json"
+        status: "failed"
   discovery:
-    - config_path: "secrets/config.json"
+    tests:
+      - config_path: "secrets/config.json"
   basic_read:
-    - config_path: "secrets/config.json"
-      configured_catalog_path: "integration_tests/configured_catalog.json"
+    tests:
+      - config_path: "secrets/config.json"
+        expect_records:
+          path: "integration_tests/expected_records.txt"
+        empty_streams:
+          - name: "ActiveScratchOrg"
+            bypass_reason: "impossible to fill the stream with data because it is an organic traffic"
+          - name: "ActiveScratchOrgFeed"
+            bypass_reason: "impossible to fill the stream with data because it is an organic traffic"
+          - name: "ActiveScratchOrgHistory"
+            bypass_reason: "impossible to fill the stream with data because it is an organic traffic"
+          - name: "ActiveScratchOrgShare"
+            bypass_reason: "impossible to fill the stream with data because it is an organic traffic"
   incremental:
-    - config_path: "secrets/config.json"
-      configured_catalog_path: "integration_tests/configured_catalog.json"
-      future_state_path: "integration_tests/future_state.json"
+    tests:
+      - config_path: "secrets/config.json"
+        configured_catalog_path: "integration_tests/incremental_catalog.json"
+        future_state:
+          future_state_path: "integration_tests/future_state.json"
   full_refresh:
-    - config_path: "secrets/config.json"
-      configured_catalog_path: "integration_tests/configured_catalog.json"
+    tests:
+      - config_path: "secrets/config.json"
+        configured_catalog_path: "integration_tests/configured_catalog.json"
diff --git a/airbyte-integrations/connectors/source-salesforce/integration_tests/configured_catalog.json b/airbyte-integrations/connectors/source-salesforce/integration_tests/configured_catalog.json
@@ -9,7 +9,7 @@
         "default_cursor_field": ["SystemModstamp"],
         "source_defined_primary_key": [["Id"]]
       },
-      "sync_mode": "incremental",
+      "sync_mode": "full_refresh",
       "destination_sync_mode": "append"
     },
     {
@@ -21,7 +21,7 @@
         "default_cursor_field": ["SystemModstamp"],
         "source_defined_primary_key": [["Id"]]
       },
-      "sync_mode": "incremental",
+      "sync_mode": "full_refresh",
       "destination_sync_mode": "append"
     },
     {
@@ -33,7 +33,7 @@
         "default_cursor_field": ["SystemModstamp"],
         "source_defined_primary_key": [["Id"]]
       },
-      "sync_mode": "incremental",
+      "sync_mode": "full_refresh",
       "destination_sync_mode": "append"
     },
     {
@@ -45,7 +45,7 @@
         "default_cursor_field": ["SystemModstamp"],
         "source_defined_primary_key": [["Id"]]
       },
-      "sync_mode": "incremental",
+      "sync_mode": "full_refresh",
       "destination_sync_mode": "append"
     },
     {
@@ -67,7 +67,7 @@
         "default_cursor_field": ["SystemModstamp"],
         "source_defined_primary_key": [["Id"]]
       },
-      "sync_mode": "incremental",
+      "sync_mode": "full_refresh",
       "destination_sync_mode": "append"
     },
     {
@@ -89,7 +89,7 @@
         "default_cursor_field": ["SystemModstamp"],
         "source_defined_primary_key": [["Id"]]
       },
-      "sync_mode": "incremental",
+      "sync_mode": "full_refresh",
       "destination_sync_mode": "append"
     },
     {
@@ -101,7 +101,7 @@
         "default_cursor_field": ["SystemModstamp"],
         "source_defined_primary_key": [["Id"]]
       },
-      "sync_mode": "incremental",
+      "sync_mode": "full_refresh",
       "destination_sync_mode": "append"
     },
     {
@@ -113,7 +113,7 @@
         "default_cursor_field": ["CreatedDate"],
         "source_defined_primary_key": [["Id"]]
       },
-      "sync_mode": "incremental",
+      "sync_mode": "full_refresh",
       "destination_sync_mode": "append"
     }
   ]