small changes

airbytehq · Apr 5, 2022 · 08254a8 · 08254a8 · github-actions · Apr 5, 2022
1 parent 5efa6e6
commit 08254a8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/airbyte-integrations/connectors/source-pivotal-tracker/acceptance-test-config.yml b/airbyte-integrations/connectors/source-pivotal-tracker/acceptance-test-config.yml
@@ -15,11 +15,6 @@ tests:
     - config_path: "secrets/config.json"
       configured_catalog_path: "integration_tests/configured_catalog.json"
       empty_streams: []
-     expect_records:
-       path: "integration_tests/expected_records.txt"
-       extra_fields: no
-       exact_order: no
-       extra_records: yes
   full_refresh:
     - config_path: "secrets/config.json"
       configured_catalog_path: "integration_tests/configured_catalog.json"
diff --git a/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_source.py b/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_source.py
@@ -2,9 +2,9 @@
 # Copyright (c) 2021 Airbyte, Inc., all rights reserved.
 #
 
-import responses
 from unittest.mock import MagicMock
 
+import responses
 from source_pivotal_tracker.source import SourcePivotalTracker
 
 

diff --git a/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_streams.py b/airbyte-integrations/connectors/source-pivotal-tracker/unit_tests/test_streams.py
@@ -4,7 +4,7 @@
 
 import responses
 from airbyte_cdk.models import SyncMode
-from source_pivotal_tracker.source import PivotalAuthenticator, Projects, ProjectMemberships, Activity, Labels, Releases, Epics, Stories
+from source_pivotal_tracker.source import Activity, Epics, Labels, PivotalAuthenticator, ProjectMemberships, Projects, Releases, Stories
 
 auth = PivotalAuthenticator("goodtoken")
 project_args = {"project_ids": [98, 99], "authenticator": auth}
Name	Value	Name	Value	Name	Value
Lines to Cover	91	Coverage	90.1	Bugs	0
Duplicated Lines (%)	0.0	Code Smells	7	Duplicated Blocks	0
Reliability Rating	A	Quality Gate Status	OK	Lines of Code	103
Security Rating	A	Vulnerabilities	0	Blocker Issues	0
Critical Issues	0	Major Issues	0	Minor Issues	7
Rule	File	Description	Message
python:mypy_index (MINOR)	source_pivotal_tracker/source.py:106	Check indexing operations	Unsupported target for indexed assignment ("Mapping[Any, Any]") . Code line: record["project_id"] = record["project"]["id"]
python:mypy_index (MINOR)	source_pivotal_tracker/source.py:72	Check indexing operations	Value of type "Optional[Mapping[str, Any]]" is not indexable . Code line: return f"projects/{stream_slice['project_id']}/{self.subpath}"
python:mypy_valid_type (MINOR)	source_pivotal_tracker/source.py:74	Check that type (annotation) is valid	Function "builtins.any" is not valid as a type . Code line: ...[str, Any] = None, **kwargs) -> Iterable[Optional[Mapping[str, any]]]:
python:mypy_arg_type (MINOR)	source_pivotal_tracker/source.py:124	Check argument types in calls	Argument 1 to "PivotalAuthenticator" has incompatible type "Optional[Any]"; expected "str" . Code line: return PivotalAuthenticator(token)
python:mypy_import (MINOR)	source_pivotal_tracker/source.py:9	Require that imported module can be found or has stubs	Library stubs not installed for "requests" (or incompatible with Python 3.7) . Code line: import requests
python:mypy_valid_type (MINOR)	source_pivotal_tracker/source.py:38	Check that type (annotation) is valid	Function "builtins.any" is not valid as a type . Code line: ...e: Mapping[str, Any], stream_slice: Mapping[str, any] = None, next_pag...
python:mypy_valid_type (MINOR)	source_pivotal_tracker/source.py:142	Check that type (annotation) is valid	Function "builtins.any" is not valid as a type . Code line: def check_connection(self, logger, config) -> Tuple[bool, any]: