rails/railtie: read adapter info without requiring an active DB conn #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
activerecord-fix
branch
3 times, most recently
from
d7d68b1 to
98aa7ca
Compare
Fixes #1222 (Airbrake Gem Attempts to Connect to Database in Databaseless App in Rails 6) Good article: https://www.bigbinary.com/blog/rails-6-changed-activerecord-base-configurations-result-to-an-object We also add a guard that makes sure there's an ActiveRecord configuration present (it can be that ActiveRecord is required but not configured; why? I have no idea but it did happen to our customer and he's got no clue either).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1222
(Airbrake Gem Attempts to Connect to Database in Databaseless App in Rails 6)
Good article:
https://www.bigbinary.com/blog/rails-6-changed-activerecord-base-configurations-result-to-an-object
We also add a guard that makes sure there's an ActiveRecord configuration
present (it can be that ActiveRecord is required but not configured; why? I have
no idea but it did happen to our customer and he's got no clue either).