rails: install all performance hooks by default #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
performance-stats-notifier-config-support
branch
3 times, most recently
from
4528080 to
e2b3746
Compare
There was a mismatch between the real name and the label.
kyrylo
force-pushed
the
performance-stats-notifier-config-support
branch
6 times, most recently
from
18ac61f to
b39243f
Compare
Previously, we were installing performance hooks based on the value from the Airbrake config. If `performance_stats` is `true`, then the hooks will be installed during initialization, if it's `false`, the hooks would never be installed. Now, `airbrake-ruby` supports remote configuration, which can change the value of `performance_stats` at runtime. In order to support this feature we must change the approach and install the hooks in either case. The `performance_stats` check is now performed inside the hooks, since this will allow us to enable/disable the feature during the runtime. A pleasant effect of this change is that we no longer need to read the config inside our railtie. This fixes #1105, which reports an issue with our existing code where we hook into `after: :load_config_initializers`. With this new approach we don't need to hook into that event anymore because we don't care at what stage the `config/initializers/airbrake.rb` is loaded.
kyrylo
force-pushed
the
performance-stats-notifier-config-support
branch
from
b39243f to
681cf87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were installing performance hooks based on the value from the
Airbrake config. If
performance_statsistrue, then the hooks will beinstalled during initialization, if it's
false, the hooks would never beinstalled.
Now,
airbrake-rubysupports remote configuration, which can change the valueof
performance_statsat runtime. In order to support this feature we mustchange the approach and install the hooks in either case. The
performance_statscheck is now performed inside the hooks, since this willallow us to enable/disable the feature during the runtime.
A pleasant effect of this change is that we no longer need to read the config
inside our railtie. This fixes #1105, which reports an issue with our existing
code where we hook into
after: :load_config_initializers. With this newapproach we don't need to hook into that event anymore because we don't care at
what stage the
config/initializers/airbrake.rbis loaded.