Make sure there are frozen string literals #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that they were added in Ruby 2.3, not 3.0.
BrianHawley
force-pushed
the
fixes_frozen_string_literals
branch
from
d3dd4c5 to
b56e568
Compare
|
FWIW, according to https://bugs.ruby-lang.org/issues/11473#note-53 Ruby 3.0 will not have frozen string literals by default. |
|
@kyrylo I am more concerned with the frozen string literal setting comments. It tends to improve performance a bit and reduce overhead if you turn that setting on. Having it not be the default makes that even more important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that they were added in Ruby 2.3, not 3.0.