Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

[cherries] Picking a few cherries #78

Merged

Conversation

john-bodley
Copy link
Collaborator

This PR picks a few cherries related to recent bug fixes. Note that I needed to pick apache#5550 to preserve the DB migration lineage. This feature is disabled by default.

to: @graceguo-supercat @michellethomas @timifasubaa

john-bodley and others added 4 commits August 13, 2018 15:35
* Template dashboard

* Fix MySQL test

* Model for user attributes

* Redirect to welcome dash

* Fix lint

* Add missing file

* Add migration script

* Fix lint

* Fix more lint

(cherry picked from commit 222b79d)
@codecov-io
Copy link

Codecov Report

Merging #78 into airbnb-master will increase coverage by 0.01%.
The diff coverage is 68.42%.

Impacted file tree graph

@@                Coverage Diff                @@
##           airbnb-master      #78      +/-   ##
=================================================
+ Coverage          63.36%   63.38%   +0.01%     
=================================================
  Files                349      350       +1     
  Lines              21932    21978      +46     
  Branches            2449     2450       +1     
=================================================
+ Hits               13898    13930      +32     
- Misses              8022     8036      +14     
  Partials              12       12
Impacted Files Coverage Δ
superset/models/user_attributes.py 100% <100%> (ø)
superset/models/__init__.py 100% <100%> (ø) ⬆️
superset/connectors/sqla/models.py 78.08% <100%> (+0.04%) ⬆️
superset/config.py 92.64% <100%> (+0.05%) ⬆️
superset/utils.py 88.67% <100%> (+0.06%) ⬆️
superset/assets/src/explore/controls.jsx 45.8% <22.22%> (-1.49%) ⬇️
superset/models/core.py 85.25% <50%> (-1.27%) ⬇️
superset/views/core.py 73.69% <75%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6713e4a...9bcb6e3. Read the comment docs.

@john-bodley john-bodley merged commit 42bdef3 into airbnb:airbnb-master Aug 13, 2018
@john-bodley john-bodley deleted the john-bodley-cherry-picks branch August 13, 2018 23:01
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
* convert source to TS

* fix lint

* convert unit test to TS

* fix rebasing issue

* fix typings

* use ts-ignore
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
Squashed commits:
[23ad0d6] feat: working box plot
[a7ed565] fix: typings
[57a62b7] feat: clarify horizontal/vertical mode
[6312737] fix: typings
[2734de3] feat: box plot types
[cb3c239] fix: typings
[7e2dcda] feat: add box plot
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants