Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Cherry-pick big number changes and code cleanup #76

Merged
merged 6 commits into from
Aug 9, 2018
Merged

Cherry-pick big number changes and code cleanup #76

merged 6 commits into from
Aug 9, 2018

Conversation

kristw
Copy link

@kristw kristw commented Aug 9, 2018 •
edited
Loading

Cherry-pick the following commits

SHA Time Log Author
39acd9f Mon Aug 6 17:26:06 2018 -0700 remove deep-equal and use _.isEqual instead (apache#5573) [Krist Wongsuphasawat]
aa14bac Mon Aug 6 14:32:29 2018 -0700 Add option for BigNumber to not start y-axis at 0 (apache#5552) [Krist Wongsuphasawat]
9d95c4c Thu Aug 2 11:45:58 2018 -0700 remove js packages that are not referenced in js code (apache#5514) [Krist Wongsuphasawat]
1b9e5d4 Thu Aug 2 10:34:36 2018 -0700 Update BigNumber design (apache#5469) [Krist Wongsuphasawat]
7158fb1 Fri Jul 6 23:09:25 2018 +0900 added a 'no_trend_line' option (apache#5356) [Yu Xiao]

@graceguo-supercat @michellethomas @john-bodley @williaster

xiaoyugit and others added 5 commits August 9, 2018 14:21
@xiaoyugit @kristw
added a 'no_trend_line' option (apache#5356)
5b600c8 
* added a 'no_trend_line' option

* added missing comma

(cherry picked from commit 7158fb1)
@kristw
resolve bignumber conflict
182ff30
@kristw
resolve package.json
06db318
@kristw
Add option for BigNumber to not start y-axis at 0 (apache#5552)
de9c03b 
* Add option to not start y-axis at 0

* Update language to positive.

(cherry picked from commit aa14bac)
@kristw
apply cherry and regenerate yarn.lock
a84fcf6
@codecov-io
Copy link

codecov-io commented Aug 9, 2018 •
edited
Loading

Codecov Report

Merging #76 into airbnb-master will decrease coverage by <.01%.
The diff coverage is 21.27%.

Impacted file tree graph

@@                Coverage Diff                @@
##           airbnb-master      #76      +/-   ##
=================================================
- Coverage          63.36%   63.36%   -0.01%     
=================================================
  Files                349      349              
  Lines              21897    21932      +35     
  Branches            2438     2449      +11     
=================================================
+ Hits               13876    13898      +22     
- Misses              8009     8022      +13     
  Partials              12       12
Impacted Files Coverage Δ
superset/assets/src/explore/visTypes.jsx 57.14% <ø> (ø) ⬆️
superset/assets/src/explore/controls.jsx 47.28% <ø> (ø) ⬆️
superset/assets/src/visualizations/BigNumber.jsx 0% <0%> (ø)
superset/assets/src/reduxUtils.js 74.57% <100%> (ø) ⬆️
superset/assets/src/modules/visUtils.js 58.33% <58.33%> (-16.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2585b...3f3616e. Read the comment docs.

williaster
williaster reviewed Aug 9, 2018
View reviewed changes
superset/assets/src/visualizations/big_number.js Outdated
@@ -93,23 +93,24 @@ function bigNumberVis(slice, payload) {

if (fd.viz_type === 'big_number') {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this file still be around?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. The merge must did something wrong.

williaster
williaster reviewed Aug 9, 2018
View reviewed changes
yarn.lock Outdated
@@ -0,0 +1,4 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this file be here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove and re-push

@williaster williaster merged commit 6713e4a into airbnb:airbnb-master Aug 9, 2018
@kristw kristw deleted the kristw/cherry-pick-big-number branch August 13, 2018 20:59
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
@soboko @zhaoyongjie
Combined two similarly-named test files, updated release notes (#76)
56f8af8 
* internal: Combined two similarly-named test files
* internal: Update CHANGELOG
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristw @codecov-io @williaster @xiaoyugit