Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[dashboard transition] Cherry pick fix for dashboard force v2 edit #63

Conversation

graceguo-supercat
Copy link
Collaborator

@graceguo-supercat graceguo-supercat commented Jul 9, 2018

@graceguo-supercat graceguo-supercat changed the title [dashboard transition] Cherry pick fix for dash force v2 edit [dashboard transition] Cherry pick fix for dashboard force v2 edit Jul 9, 2018
Copy link

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@codecov-io
Copy link

Codecov Report

Merging #63 into airbnb-master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##           airbnb-master      #63      +/-   ##
=================================================
- Coverage           61.5%   61.49%   -0.01%     
=================================================
  Files                371      371              
  Lines              23563    23566       +3     
  Branches            2741     2742       +1     
=================================================
  Hits               14493    14493              
- Misses              9058     9061       +3     
  Partials              12       12
Impacted Files Coverage Δ
.../src/dashboard/deprecated/v1/components/Header.jsx 0% <ø> (ø) ⬆️
...c/dashboard/deprecated/v1/components/Dashboard.jsx 0% <0%> (ø) ⬆️
superset/views/core.py 72.89% <0%> (-0.11%) ⬇️
...rc/dashboard/deprecated/v1/components/Controls.jsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea88054...5acdc62. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit b5c571b into airbnb:airbnb-master Jul 9, 2018
@graceguo-supercat graceguo-supercat deleted the gg-CherryPick-FixDashForceV2Edit branch July 23, 2018 17:53
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
* unify the metric format

* fix test

* fix lint

* fix lint

* change per comments in pr
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants