Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Pin reactable to version 1.0.2 so it works in production mode #116

Merged
merged 2 commits into from
Sep 19, 2018

Conversation

kristw
Copy link

@kristw kristw commented Sep 19, 2018

reactable 1.1.0 works for development (npm run dev) but not production (npm run build)
while 1.0.2 works for production not development.

Adding this hotfix to enable our staging and production deployment to move forward.

abdulrahman-khankan/reactable#3

@graceguo-supercat @john-bodley

@kristw kristw changed the title Fix reactable version 1.0.2 so it works in production mode Pin reactable to version 1.0.2 so it works in production mode Sep 19, 2018
@codecov-io
Copy link

codecov-io commented Sep 19, 2018

Codecov Report

Merging #116 into airbnb-master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           airbnb-master     #116   +/-   ##
==============================================
  Coverage          63.28%   63.28%           
==============================================
  Files                363      363           
  Lines              22255    22255           
  Branches            2503     2503           
==============================================
  Hits               14083    14083           
  Misses              8160     8160           
  Partials              12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc07ddb...41759d4. Read the comment docs.

Copy link
Collaborator

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat graceguo-supercat merged commit f48eddf into airbnb:airbnb-master Sep 19, 2018
@kristw kristw deleted the kristw-reactable-1.0.2 branch September 20, 2018 21:52
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
* feat: 🎸 Improved QueryObject to handle more fields

The commit is to ensure the feature parity between frontend and backend
QueryOjbect

* test: 💍 Added tests to improve the coverage
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants