Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

fix: Pivot table not sorting formatted numeric column properly (#5709) #108

Merged

Conversation

john-bodley
Copy link
Collaborator

  • fix: Pivot table not sorting formatted numeric column properly

  • refactor(lint): fixed lint error

(cherry picked from commit 4121d57)

to: @graceguo-supercat @kristw @michellethomas @timifasubaa @williaster

…e#5709)

* fix: Pivot table not sorting formatted numeric column properly

* refactor(lint): fixed lint error

(cherry picked from commit 4121d57)
@codecov-io
Copy link

codecov-io commented Sep 13, 2018

Codecov Report

Merging #108 into airbnb-master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##           airbnb-master     #108      +/-   ##
=================================================
- Coverage          63.42%   63.41%   -0.01%     
=================================================
  Files                356      356              
  Lines              22168    22169       +1     
  Branches            2498     2498              
=================================================
  Hits               14059    14059              
- Misses              8097     8098       +1     
  Partials              12       12
Impacted Files Coverage Δ
superset/assets/src/visualizations/pivot_table.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb4086...d4c5402. Read the comment docs.

Copy link
Collaborator

@conglei conglei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@john-bodley john-bodley merged commit 20a6db9 into airbnb:airbnb-master Sep 13, 2018
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
* Set default color scheme for the color registries

* fix: Add unit test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants