Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Cherry-picks: Allow users to choose color for BigNumber #102

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Cherry-picks: Allow users to choose color for BigNumber #102

merged 2 commits into from
Aug 28, 2018

Conversation

kristw
Copy link

@kristw kristw commented Aug 27, 2018

Cherry-pick the following commit(s):

SHA Time Log Author
0781cf2 Mon Aug 27 15:46:52 2018 -0700 [bugfix] BigNumber crash, Horizon indent and Myanmar geojson (apache#5746) (apache/master) Krist Wongsuphasawat
b92e730 Wed Aug 22 10:27:19 2018 -0700 Allow users to select color for big number (apache#5694) Hugh A. Miles II

@john-bodley @conglei @graceguo-supercat @kristw @michellethomas @timifasubaa @williaster

hughhhh and others added 2 commits August 27, 2018 15:52
@hughhhh @kristw
Allow users to select color for big number (apache#5694)
addade3 
* allow user to choose color

* add color control

* remove rgbToHex reference

* change to color picker control

* add d3-color

* remove module

* use d3-colors

* add semicolon

(cherry picked from commit b92e730)
@kristw
[bugfix] BigNumber crash, Horizon indent and Myanmar geojson (apache#…
0d3baae 
…5746)

* fix myanmar geojson

* fix indent of horizon in dashboard

* Fix bignumber crash when color_picker is undefined

(cherry picked from commit 0781cf2)
@kristw kristw changed the title [WIP] Cherry-pick(s): <description> Cherry-picks: Allow users to choose color for BigNumber Aug 27, 2018
@codecov-io
Copy link

codecov-io commented Aug 27, 2018 •
edited
Loading

Codecov Report

Merging #102 into airbnb-master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##           airbnb-master     #102      +/-   ##
=================================================
- Coverage          63.18%   63.17%   -0.02%     
=================================================
  Files                352      352              
  Lines              22054    22059       +5     
  Branches            2470     2471       +1     
=================================================
  Hits               13935    13935              
- Misses              8107     8112       +5     
  Partials              12       12
Impacted Files Coverage Δ
superset/assets/src/explore/visTypes.jsx 57.14% <ø> (ø) ⬆️
superset/assets/src/visualizations/BigNumber.jsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424ddce...0d3baae. Read the comment docs.

@kristw kristw merged commit c2bc9f3 into airbnb:airbnb-master Aug 28, 2018
@kristw kristw deleted the kristw-cherry-aug27v3 branch August 29, 2018 22:26
@kristw kristw restored the kristw-cherry-aug27v3 branch August 29, 2018 22:26
@kristw kristw deleted the kristw-cherry-aug27v3 branch September 11, 2018 05:22
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
@kristw @zhaoyongjie
fix: invalid margin breaking chart (#102)
6d8ebc8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michellethomas michellethomas michellethomas approved these changes

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kristw @codecov-io @michellethomas @williaster @hughhhh