[fix] Move theme registration to src #182
Conversation
|
@ljharb I believe public interface being exposed hasn't changed, so this should be |
|
@philipfweiss all accessible files are part of the public interface. |
philipfweiss
force-pushed
the
pw--move-theme-registration-to-src
branch
from
ab58b62 to
e2a999a
Compare
philipfweiss
force-pushed
the
pw--move-theme-registration-to-src
branch
from
e2a999a to
64a665a
Compare
.storybook-css/config.js
Outdated
| @@ -2,7 +2,7 @@ import { configure } from '@kadira/storybook'; | |||
| import ThemedStyleSheet from 'react-with-styles/lib/ThemedStyleSheet'; | |||
| import aphroditeInterface from 'react-with-styles-interface-aphrodite'; | |||
| import '../css/rheostat.css'; | |||
| import registerCSSInterfaceWithDefaultTheme from '../scripts/utils/registerCSSInterfaceWithDefaultTheme'; | |||
| import registerCSSInterfaceWithDefaultTheme from '../lib/utils/registerCSSInterfaceWithDefaultTheme'; | |||
There was a problem hiding this comment.
I don't think we want this update. Let's pull from src here.
.storybook/config.js
Outdated
| @@ -1,7 +1,7 @@ | |||
| import { configure } from '@kadira/storybook'; | |||
| import ThemedStyleSheet from 'react-with-styles/lib/ThemedStyleSheet'; | |||
| import aphroditeInterface from 'react-with-styles-interface-aphrodite'; | |||
| import registerInterfaceWithDefaultTheme from '../scripts/utils/registerInterfaceWithDefaultTheme'; | |||
| import registerInterfaceWithDefaultTheme from '../lib/utils/registerInterfaceWithDefaultTheme'; | |||
There was a problem hiding this comment.
I don't think we want this update. Let's pull from src here. Otherwise we'll have to build all the js every time we run storybook
src/utils/.eslintrc
Outdated
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Um, I don't think we want this eslintrc here. the src/utils folder should not be importing dev dependencies.
| @@ -1,3 +1,5 @@ | |||
| /* This file should be removed in the next major version update of Rheostat */ | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -1,3 +1,5 @@ | |||
| /* This file should be removed in the next major version update of Rheostat */ | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Looks great to me! |
Addresses #181. Moves the theme registration helper functions into src, so they will be compiled during the build step. Also updates the callsites of these functions to point into
lib/utils/<x>, as desired.Keeps a copy of these files in
scripts/utilsas well, for backwards-compatibility. These files should be removed at the next major version update.