Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[update] React With Styles Namespacing #172

Merged
merged 4 commits into from
Jul 5, 2018
Merged

[update] React With Styles Namespacing #172

merged 4 commits into from
Jul 5, 2018

Conversation

philipfweiss
Copy link
Contributor

@philipfweiss philipfweiss commented Jul 5, 2018 •
edited by majapw
Loading

Same as
#169
#170

But the last PRs were not merged into master.

@philipfweiss philipfweiss requested a review from majapw July 5, 2018 20:18
majapw
majapw approved these changes Jul 5, 2018
View reviewed changes
Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I updated the description because I think the PRs actually meant to be referenced were #169 and #170.

Looks great to me!

@philipfweiss philipfweiss merged commit 563f6a7 into master Jul 5, 2018
@philipfweiss philipfweiss deleted the pw--react-with-styles-namespacing branch July 5, 2018 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@majapw majapw majapw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipfweiss @ljharb @majapw