Add storybook css interface (4/7) #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipfweiss
changed the title
philipfweiss
changed the title
philipfweiss
changed the base branch from
master
to
pw--clean-up-rheostat-CSS-theming
philipfweiss
commented
Jun 29, 2018
| @@ -770,7 +765,6 @@ class Rheostat extends React.Component { | |||
| ref={this.setHandleContainerNode} | |||
| {...css( | |||
| styles.handleContainer, | |||
| handleContainerStyle, | |||
There was a problem hiding this comment.
Turns out that this didn't actually do anything, and was just being overridden. Since it is not overridden with the CSS interface, and was causing graphical issues, I removed it.
ljharb
reviewed
Jun 30, 2018
css/styles.css
Outdated
| @@ -0,0 +1,113 @@ | |||
| .DefaultProgressBar__vertical { | |||
There was a problem hiding this comment.
should this file be gitignored (altho not npm-ignored), and generated as part of build output?
There was a problem hiding this comment.
Hmm what is the rationale for not putting it on Github? On one hand it's a generated file, but on the other it might be useful for someone skimming the repository online or right after cloning.
There was a problem hiding this comment.
generally those aren't supported use cases; you can use http://unpkg.com/react-dates/ if you want to browse generated output.
css/styles.css
Outdated
| width: 15px; | ||
| top: 0px; | ||
| height: 100% | ||
| } |
There was a problem hiding this comment.
all files should have trailing newlines
package.json
Outdated
| @@ -14,6 +14,7 @@ | |||
| "prepublish": "npm run build", | |||
| "lint": "eslint --ext .js,.jsx src test stories", | |||
| "storybook": "start-storybook -p 9001", | |||
| "storybook:css": "npm run build:css && start-storybook -p 6006 -c .storybook-css", | |||
There was a problem hiding this comment.
"prestorybook:css": "npm run build:css"?
.storybook-css/config.js
Outdated
| registerCSSInterfaceWithDefaultTheme(); | ||
|
|
||
| function loadStories() { | ||
| require('../stories/ExampleSlider.jsx'); |
There was a problem hiding this comment.
this should omit the extension
philipfweiss
force-pushed
the
pw--clean-up-rheostat-CSS-theming
branch
from
e63b09e to
de87561
Compare
philipfweiss
force-pushed
the
pw--add-storybook-css-interface
branch
2 times, most recently
from
b648666 to
f1ddaa2
Compare
philipfweiss
force-pushed
the
pw--clean-up-rheostat-CSS-theming
branch
from
de87561 to
daedb98
Compare
philipfweiss
force-pushed
the
pw--add-storybook-css-interface
branch
2 times, most recently
from
2d0f1e8 to
3a0e8ce
Compare
philipfweiss
force-pushed
the
pw--clean-up-rheostat-CSS-theming
branch
2 times, most recently
from
cf46dd1 to
8cd1c2f
Compare
philipfweiss
force-pushed
the
pw--add-storybook-css-interface
branch
3 times, most recently
from
1cbcb92 to
532c167
Compare
philipfweiss
force-pushed
the
pw--clean-up-rheostat-CSS-theming
branch
from
8cd1c2f to
cdf7134
Compare
philipfweiss
force-pushed
the
pw--add-storybook-css-interface
branch
from
532c167 to
3121296
Compare
philipfweiss
force-pushed
the
pw--clean-up-rheostat-CSS-theming
branch
2 times, most recently
from
4cfda86 to
e70531a
Compare
philipfweiss
force-pushed
the
pw--add-storybook-css-interface
branch
from
3121296 to
64e6b9c
Compare
philipfweiss
force-pushed
the
pw--clean-up-rheostat-CSS-theming
branch
3 times, most recently
from
926dc37 to
d39970f
Compare
philipfweiss
force-pushed
the
pw--add-storybook-css-interface
branch
from
64e6b9c to
1a0d6c4
Compare
majapw
requested changes
Jul 2, 2018
.gitignore
Outdated
| @@ -7,6 +7,7 @@ coverage | |||
| build | |||
| css/rheostat.css | |||
| .nyc_output | |||
| css/styles.css | |||
There was a problem hiding this comment.
didn't we change this naming?
package.json
Outdated
| @@ -71,6 +73,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "airbnb-prop-types": "^2.10.0", | |||
| "clean-css": "^4.1.11", | |||
There was a problem hiding this comment.
again, not a dep, let's remove this package from here, it's already in dev deps
philipfweiss
force-pushed
the
pw--add-storybook-css-interface
branch
from
1a0d6c4 to
eedb9a2
Compare
ljharb
approved these changes
Jul 3, 2018
philipfweiss
force-pushed
the
pw--clean-up-rheostat-CSS-theming
branch
from
d39970f to
8eaa55e
Compare
philipfweiss
force-pushed
the
pw--add-storybook-css-interface
branch
from
eedb9a2 to
f5bd378
Compare
philipfweiss
changed the base branch from
pw--clean-up-rheostat-CSS-theming
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
storybook:csscommand to package JSON which instantiates the storybook withreact-with-styles-css-interface.Builds off of
#162
#163