Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a few unused imports #2246

Closed
wants to merge 1 commit into from
Closed

Remove a few unused imports #2246

wants to merge 1 commit into from

Conversation

hanton
Copy link
Contributor

@hanton hanton commented Dec 4, 2023

This PR removes unused Swift imports, enhancing code clarity and easing maintenance. Although their direct effect on compilation time is minimal, in extensive projects with numerous dependencies, these unused imports might slightly increase overhead. The removal ensures a cleaner, more efficient codebase and clearer, more manageable dependencies.

@calda
Copy link
Member

calda commented Dec 4, 2023

Thanks, can you please also update the PR so CI passes? The build is currently failing in Xcode 13.4, which uses Swift 5.6.

@calda
Copy link
Member

calda commented Dec 8, 2023

I'm going to close this PR for now since CI is not passing. Feel free to re-open if you update the PR to try and fix the CI failure in Xcode 13.4 / Swift 5.6.

@calda calda closed this Dec 8, 2023
@hanton
Copy link
Contributor Author

hanton commented Dec 10, 2023

Sorry for the late reply. I didn't notice we are still supporting Xcode 13.4.1 and Swift 5.6, will try to fix the CI failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants