Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support box position in Document Data #2139

Merged
merged 6 commits into from
Nov 11, 2022
Merged

Support box position in Document Data #2139

merged 6 commits into from
Nov 11, 2022

Conversation

gpeal
Copy link
Collaborator

@gpeal gpeal commented Oct 2, 2022

Fixes #2131

@LottieSnapshotBot
Copy link

Snapshot Tests
28: Report Diff

@ryanhurststrava
Copy link
Contributor

I did some testing on this branch. Looks like this causes some issues with animation files that also have a sz attribute like this one
web:
web
5.2.1 snapshot:
521snapshot
gpeal/document-data-position:
document-data-position

@gpeal
Copy link
Collaborator Author

gpeal commented Oct 4, 2022

Yup, that's why I'm not landing it yet! The snapshot tests caught it, too.

@ryanhurststrava
Copy link
Contributor

Oh I see. Well let me know if there's anything I can help with

@LottieSnapshotBot
Copy link

Snapshot Tests
28: Report Diff

@LottieSnapshotBot
Copy link

Snapshot Tests
28: Report Diff

@LottieSnapshotBot
Copy link

Snapshot Tests
28: Report Diff

@LottieSnapshotBot
Copy link

Snapshot Tests
28: Report Diff

@LottieSnapshotBot
Copy link

Snapshot Tests
28: Report Diff

@gpeal gpeal changed the title Support "ps" in Document Data Support box position in Document Data Nov 11, 2022
@gpeal gpeal merged commit 592c5f6 into master Nov 11, 2022
@gpeal gpeal deleted the gpeal/document-data-position branch November 11, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gpeal @LottieSnapshotBot @ryanhurststrava