De-dupe gradient stops

[gpeal]

Refer to code comments for more info:
Before:

After:

[denis-bezrukov]

nit:

Suggested change

	float[] merged = new float[mergedNotTruncated.length - numDuplicates];
	System.arraycopy(mergedNotTruncated, 0, merged, 0, merged.length);
	return merged;
	return Arrays.copyOf(mergedNotTruncated, mergedNotTruncated.lengh - numDuplicates);

[gpeal]

Done!

[denis-bezrukov]

isn't mergeIndex can be replaced by i?

[gpeal]

Yup!

[denis-bezrukov]

nit could be elvis

Suggested change

	final float a;
	if (aIndex < arrayA.length) {
	a = arrayA[aIndex];
	} else {
	a = Float.NaN;
	}
	final float a = aIndex < arrayA.length ? arrayA[aIndex] : Float.NaN

[gpeal]

👍

[imbryk]

@gpeal @denis-bezrukov
This PR is crashing the app for quite a few complex animations we use.
I'm not able to identify the place in our animations, as they are really big, but I've found that the problem is that this PR changes the length of color array in GradientColor which results in https://github.com/airbnb/lottie-android/blob/master/lottie/src/main/java/com/airbnb/lottie/animation/keyframe/GradientColorKeyframeAnimation.java being created with keyframes which have GradientColors of different lengths, which eventually crashes at the GradientColor.lerp method with java.lang.ArrayIndexOutOfBoundsException

This can theoretically be simply fixed not to crash, but I believe that would completely break the intended gradient animation.

If the problem solved by this PR was needed mostly for static lottie files, maybe you could apply this change only when parsing a static value:
https://github.com/airbnb/lottie-android/blob/master/lottie/src/main/java/com/airbnb/lottie/parser/KeyframeParser.java#L369
but when parsing animation keep the old way of parsing it (i.e. keeping all values)

[gpeal]

@imbryk Could you attach an animation that is crashing? I'd rather fix the problem than fall back to something wrong.

[imbryk]

@gpeal would it be possible to send it to you privately?

[gpeal]

@imbryk Yeah, go ahead and DM it to me on Twitter but open a new issue saying you did that so it doesn't slip through the cracks the next time I work on this.

[imbryk]

@gpeal I am not able to send you a message on twitter 🤷 - please grab the files from gdrive:
https://drive.google.com/drive/folders/1LOiSaIJq1LJL848Ne8rA9Omrn2ErynfY