Moving to using keyPathName as string to reduce allocations and be mo…

…re consistent with iOS
airbnb · Oct 22, 2021 · c5ea9b4 · c5ea9b4
1 parent a9bcd9b
commit c5ea9b4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lottie/src/main/java/com/airbnb/lottie/TextDelegate.java b/lottie/src/main/java/com/airbnb/lottie/TextDelegate.java
@@ -47,11 +47,11 @@ public TextDelegate(@SuppressWarnings("NullableProblems") LottieDrawable drawabl
   /**
    * Override this to replace the animation text with something dynamic. This can be used for
    * translations or custom data.
-   * @param path the name of the layer with text
+   * @param keyPathName the name of the layer with text
    * @param input the string at the layer with text
    * @return a String to use for the specific data, by default this is the same as getText(input)
    */
-  public String getText(KeyPath path, String input) {
+  public String getText(String keyPathName, String input) {
     return getText(input);
   }
 
@@ -96,11 +96,11 @@ public void invalidateAllText() {
   }
 
   @RestrictTo(RestrictTo.Scope.LIBRARY)
-  public final String getTextInternal(KeyPath path, String input) {
+  public final String getTextInternal(String keyPathName, String input) {
     if (cacheText && stringMap.containsKey(input)) {
       return stringMap.get(input);
     }
-    String text = getText(path, input);
+    String text = getText(keyPathName, input);
     if (cacheText) {
       stringMap.put(input, text);
     }

diff --git a/lottie/src/main/java/com/airbnb/lottie/model/layer/TextLayer.java b/lottie/src/main/java/com/airbnb/lottie/model/layer/TextLayer.java
@@ -246,7 +246,7 @@ private void drawTextWithFont(
     String text = documentData.text;
     TextDelegate textDelegate = lottieDrawable.getTextDelegate();
     if (textDelegate != null) {
-      text = textDelegate.getTextInternal(new KeyPath(getName()), text);
+      text = textDelegate.getTextInternal(getName(), text);
     }
     fillPaint.setTypeface(typeface);
     float textSize;