This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Remove dependencies on babel-template and babel-plugin-syntax-dynamic-import #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Oct 6, 2018
| }); | ||
| path.parentPath.replaceWith(newImport); | ||
| return { | ||
| manipulateOptions(opts, parserOpts) { |
There was a problem hiding this comment.
let's add a comment with the inherits: syntax code and instructions to use it instead of this inlined code once this package has dropped babel 6 support?
…-import Use the template provided by the babel plugin API instead and use the dynamic import syntax options directly.
sharmilajesupaul
force-pushed
the
shar--refactor-index
branch
from
55bf699 to
e4decee
Compare
ljharb
added a commit
to airbnb/babel-plugin-dynamic-import-node
that referenced
this pull request
Oct 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in: #50 (comment), we can configure this plugin in a way that might work with both Babel 6 and 7.
This change use
templateprovided by the babel plugin API instead of importing frombabel-templateand configures the dynamic import syntax options directly instead of using the external plugin.cc. @ljharb