Fix KeyError on solitary abort marker. #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikulmar
force-pushed
the
fix/fetcher-keyerror
branch
from
428c4dd to
36ef904
Compare
ods
reviewed
Sep 10, 2021
pikulmar
force-pushed
the
fix/fetcher-keyerror
branch
from
36ef904 to
49c4be4
Compare
ods
reviewed
Sep 10, 2021
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
==========================================
- Coverage 97.93% 97.89% -0.04%
==========================================
Files 31 31
Lines 5279 5279
==========================================
- Hits 5170 5168 -2
- Misses 109 111 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ods
approved these changes
Sep 13, 2021
tvoinarovskyi
requested review from
tvoinarovskyi
and removed request for
tvoinarovskyi
ods
added a commit
that referenced
this pull request
Sep 14, 2021
GrigoriParko
pushed a commit
to Parkopedia/ppds-aiokafka
that referenced
this pull request
Apr 15, 2022
* Fix KeyError on solitary abort marker. * Add regression test for solitary abort marker. * Fix regression test. * Use non-extension builder for test setup. * Add comments to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #781
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.