Fix missing reader_c.c file in Makefile .install-deps
#9723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make install-dev` was not creating `reader_c.c` which meant to get a working dev env, `make cythonize` had to be run before `make install-dev`
bdraco
added
bot:chronographer:skip
bdraco
changed the title
reader_c.c file in Makefile .install-deps
CodSpeed Performance ReportMerging #9723 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9723 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 117 117
Lines 35787 35787
Branches 4239 4239
=======================================
Hits 35313 35313
Misses 319 319
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9725 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 9, 2024
(cherry picked from commit ab9b566)
bdraco
added a commit
that referenced
this pull request
Nov 9, 2024
…akefile `.install-deps` (#9725) Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make install-devwas not creatingreader_c.cwhich meant to get a working dev env,make cythonizehad to be run beforemake install-dev