Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9543/6ae2f05 backport][3.11] Add a PXD only Cython extension for the WebSocket reader to improve performance #9548

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 27, 2024

(cherry picked from commit 6ae2f05)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 27, 2024
@bdraco bdraco force-pushed the patchback/backports/3.11/6ae2f053e9989a759b140e42937e2138f80e502d/pr-9543 branch from d05ba2e to c199c89 Compare October 27, 2024 23:26
Copy link

codspeed-hq bot commented Oct 27, 2024

CodSpeed Performance Report

Merging #9548 will improve performances by ×2

Comparing patchback/backports/3.11/6ae2f053e9989a759b140e42937e2138f80e502d/pr-9543 (828f775) with 3.11 (751af18)

Summary

⚡ 1 improvements
✅ 3 untouched benchmarks

Benchmarks breakdown

Benchmark 3.11 patchback/backports/3.11/6ae2f053e9989a759b140e42937e2138f80e502d/pr-9543 Change
test_read_one_hundred_websocket_text_messages[pyloop] 1,322.8 µs 647.4 µs ×2

@bdraco bdraco changed the title Add a PXD only Cython extension for the WebSocket reader to improve performance (#9543) [PR #9543/6ae2f05 backport][3.11] Add a PXD only Cython extension for the WebSocket reader to improve performance Oct 27, 2024
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.84%. Comparing base (751af18) to head (828f775).
Report is 275 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9548   +/-   ##
=======================================
  Coverage   97.83%   97.84%           
=======================================
  Files         113      114    +1     
  Lines       35286    35315   +29     
  Branches     4233     4236    +3     
=======================================
+ Hits        34523    34554   +31     
+ Misses        571      570    -1     
+ Partials      192      191    -1     
Flag Coverage Δ
CI-GHA 97.72% <99.55%> (+<0.01%) ⬆️
OS-Linux 97.42% <99.55%> (+<0.01%) ⬆️
OS-Windows 94.32% <23.89%> (-0.50%) ⬇️
OS-macOS 96.64% <23.89%> (-0.47%) ⬇️
Py-3.10.11 96.50% <23.89%> (-0.47%) ⬇️
Py-3.10.15 96.91% <99.55%> (+<0.01%) ⬆️
Py-3.11.10 96.98% <99.55%> (+<0.01%) ⬆️
Py-3.11.9 96.58% <23.89%> (-0.49%) ⬇️
Py-3.12.7 97.45% <99.55%> (+<0.01%) ⬆️
Py-3.13.0 97.44% <99.55%> (+<0.01%) ⬆️
Py-3.9.13 96.42% <24.00%> (-0.47%) ⬇️
Py-3.9.20 96.82% <98.66%> (-0.01%) ⬇️
Py-pypy7.3.16 96.46% <97.33%> (+<0.01%) ⬆️
VM-macos 96.64% <23.89%> (-0.47%) ⬇️
VM-ubuntu 97.42% <99.55%> (+<0.01%) ⬆️
VM-windows 94.32% <23.89%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Oct 27, 2024

Tested on production Home Assistant.

All working as expected

@bdraco bdraco marked this pull request as ready for review October 27, 2024 23:58
@bdraco bdraco merged commit 765a5c2 into 3.11 Oct 27, 2024
36 of 37 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/6ae2f053e9989a759b140e42937e2138f80e502d/pr-9543 branch October 27, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant