-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small speed up to starting client requests #9386
Conversation
master can handle 13% more RPS than 3.9.5 and the performance is a bit more consistent until gc happens There is still a lot of time spent in all the aiohttp/aiohttp/client_reqrep.py Line 258 in d684195
There are so many options that its always going to be difficult to optimize them without making more invasive changes which probably aren't worth it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9386 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 107 107
Lines 34995 34995
Branches 4146 4146
=======================================
Hits 34492 34492
Misses 335 335
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9388 🤖 @patchback |
(cherry picked from commit 803d818)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9389 🤖 @patchback |
(cherry picked from commit 803d818)
…requests (#9388) Co-authored-by: J. Nick Koston <[email protected]>
…requests (#9389) Co-authored-by: J. Nick Koston <[email protected]>
What do these changes do?
Avoid some checks for uncommon cases
Avoid
lower()
ing default values that are rarely set.Are there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no