Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error pointer on linebreaks #7480

Merged
merged 4 commits into from
Aug 5, 2023
Merged

Fix error pointer on linebreaks #7480

merged 4 commits into from
Aug 5, 2023

Conversation

Dreamsorcerer
Copy link
Member

Fixes #7468.

@Dreamsorcerer Dreamsorcerer requested a review from asvetlov as a code owner August 5, 2023 22:20
@Dreamsorcerer Dreamsorcerer changed the title Fix Fix error pointer on linebreaks Aug 5, 2023
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 5, 2023 •
edited
Loading

Codecov Report

Merging #7480 (c4d6b9c) into master (878ac7d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7480   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files         106      106           
  Lines       31441    31448    +7     
  Branches     3565     3567    +2     
=======================================
+ Hits        30585    30592    +7     
  Misses        652      652           
  Partials      204      204
Flag Coverage Δ
CI-GHA 97.22% <100.00%> (+<0.01%) ⬆️
OS-Linux 96.89% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.34% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.57% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 95.27% <100.00%> (+<0.01%) ⬆️
Py-3.10.12 96.78% <100.00%> (+<0.01%) ⬆️
Py-3.11.4 96.49% <28.57%> (-0.02%) ⬇️
Py-3.8.10 95.24% <100.00%> (+<0.01%) ⬆️
Py-3.8.17 96.71% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 95.23% <100.00%> (+<0.01%) ⬆️
Py-3.9.17 96.74% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.11 96.30% <28.57%> (-0.02%) ⬇️
VM-macos 96.57% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 96.89% <100.00%> (+<0.01%) ⬆️
VM-windows 95.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tests/test_http_parser.py 99.10% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer Dreamsorcerer merged commit 1fb06bb into master Aug 5, 2023
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-3 branch August 5, 2023 23:33
@patchback
Copy link
Contributor

patchback bot commented Aug 5, 2023 •
edited
Loading

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/1fb06bbc10a7bd621c694a33137cf16b23b07a02/pr-7480

Backported as #7482

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 5, 2023
@Dreamsorcerer @patchback
Fix error pointer on linebreaks (#7480)
d44c758 
Fixes #7468.

(cherry picked from commit 1fb06bb)
@patchback patchback bot mentioned this pull request Aug 5, 2023
Merged
@patchback
Copy link
Contributor

patchback bot commented Aug 5, 2023 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/1fb06bbc10a7bd621c694a33137cf16b23b07a02/pr-7480

Backported as #7483

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Aug 5, 2023
Merged
patchback bot pushed a commit that referenced this pull request Aug 5, 2023
@Dreamsorcerer @patchback
Fix error pointer on linebreaks (#7480)
b28452d 
Fixes #7468.

(cherry picked from commit 1fb06bb)
Dreamsorcerer added a commit that referenced this pull request Aug 6, 2023
@patchback @Dreamsorcerer
[PR #7480/1fb06bbc backport][3.9] Fix error pointer on linebreaks (#7483
9106435 
)

**This is a backport of PR #7480 as merged into master
(1fb06bb).**

Fixes #7468.

Co-authored-by: Sam Bull <[email protected]>
Dreamsorcerer added a commit that referenced this pull request Aug 6, 2023
@patchback @Dreamsorcerer
[PR #7480/1fb06bbc backport][3.8] Fix error pointer on linebreaks (#7482
8129d26 
)

**This is a backport of PR #7480 as merged into master
(1fb06bb).**

Fixes #7468.

Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backwards incompatibility with header parsing from 3.8.4 to 3.8.5
1 participant
@Dreamsorcerer