Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsafe .abort() call #7280

Closed
wants to merge 5 commits into from
Closed

Fix unsafe .abort() call #7280

wants to merge 5 commits into from

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented May 13, 2023

Possibly fixes #7252.
Definite fix for elastic/rally#1714.

.abort() is not safe to call if the transport is already closed, since Python 3.11.1:
python/cpython#98540

@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Merging #7280 (6832189) into master (b2a7983) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #7280      +/-   ##
==========================================
- Coverage   97.31%   97.31%   -0.01%     
==========================================
  Files         107      107              
  Lines       31485    31488       +3     
  Branches     3937     3937              
==========================================
+ Hits        30640    30642       +2     
- Misses        641      642       +1     
  Partials      204      204              
Flag Coverage Δ
CI-GHA 97.22% <80.00%> (-0.01%) ⬇️
OS-Linux 96.87% <80.00%> (-0.01%) ⬇️
OS-Windows 95.29% <80.00%> (-0.01%) ⬇️
OS-macOS 96.46% <80.00%> (-0.01%) ⬇️
Py-3.10.11 96.97% <80.00%> (-0.01%) ⬇️
Py-3.11.0 96.41% <80.00%> (-0.01%) ⬇️
Py-3.7.16 96.70% <80.00%> (-0.01%) ⬇️
Py-3.7.9 95.17% <80.00%> (-0.01%) ⬇️
Py-3.8.10 95.08% <80.00%> (-0.01%) ⬇️
Py-3.8.16 96.61% <80.00%> (-0.01%) ⬇️
Py-3.9.13 95.08% <80.00%> (-0.01%) ⬇️
Py-3.9.16 96.63% <80.00%> (-0.01%) ⬇️
Py-pypy7.3.11 94.13% <80.00%> (-0.01%) ⬇️
VM-macos 96.46% <80.00%> (-0.01%) ⬇️
VM-ubuntu 96.87% <80.00%> (-0.01%) ⬇️
VM-windows 95.29% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/connector.py 94.47% <0.00%> (-0.15%) ⬇️
tests/test_connector.py 97.88% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the leak is gone with cleanup closed set to True on my production systems

@Dreamsorcerer
Copy link
Member Author

Closing in favour of python/cpython#104485
Should be released in Python 3.11.4.

@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-4 branch February 5, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak with Python 3.11.2
2 participants