-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unsafe .abort() call #7280
Fix unsafe .abort() call #7280
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7280 +/- ##
==========================================
- Coverage 97.31% 97.31% -0.01%
==========================================
Files 107 107
Lines 31485 31488 +3
Branches 3937 3937
==========================================
+ Hits 30640 30642 +2
- Misses 641 642 +1
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the leak is gone with cleanup closed set to True on my production systems
Closing in favour of python/cpython#104485 |
Possibly fixes #7252.
Definite fix for elastic/rally#1714.
.abort()
is not safe to call if the transport is already closed, since Python 3.11.1:python/cpython#98540