[PR #6756/72d3d4b1 backport][3.8] Fix pip reinstallation on windows due to constraints #6911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
(cherry picked from commit 72d3d4b)
webknjaz
deleted the
patchback/backports/3.8/72d3d4b1f68cca5ad15ef50bffb0419b798c7f23/pr-6756
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #6756 as merged into master (72d3d4b).
What do these changes do?
Fix for constantly failing CI on windows agents.
Description
We have pinned pip version in constraints.txt file:
aiohttp/requirements/constraints.txt
Line 260 in 08ca779
So when you call
pip install ... -c constraints.txtit will downgrade/upgrade pip depending on the currently installed version. This works fine on all platforms except windows, which forces you to explicitly usepython -m pip install ...when dealing with the pip package itself.Since
python -m pip install ...command is a completely legit replacement forpip install ...(examples from the pip wiki), I decided to updateMakefilewith it.