Makefile: replace which(1) with more portable command -v
#6784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `which(1)` program is not provided by the POSIX base system and causes the Makefile to misbehave when it is missing on the system. `command -v` is a portable replacement that is provided by the shell as a builtin and that is guaranteed to exist by POSIX.
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #6784 +/- ##
==========================================
- Coverage 93.44% 93.44% -0.01%
==========================================
Files 104 104
Lines 30627 30627
Branches 3076 3076
==========================================
- Hits 28620 28619 -1
Misses 1838 1838
- Partials 169 170 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #6787 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 12, 2022
The `which(1)` program is not provided by the POSIX base system and causes the Makefile to misbehave when it is missing on the system. `command -v` is a portable replacement that is provided by the shell as a builtin and that is guaranteed to exist by POSIX. (cherry picked from commit 3a41da0)
Merged
5 tasks
Dreamsorcerer
pushed a commit
that referenced
this pull request
Jun 12, 2022
…6787) The `which(1)` program is not provided by the POSIX base system and causes the Makefile to misbehave when it is missing on the system. `command -v` is a portable replacement that is provided by the shell as a builtin and that is guaranteed to exist by POSIX. (cherry picked from commit 3a41da0) Co-authored-by: Michał Górny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The
which(1)program is not provided by the POSIX base systemand causes the Makefile to misbehave when it is missing on the system.
command -vis a portable replacement that is provided by the shellas a builtin and that is guaranteed to exist by POSIX.
Are there changes in behavior for the user?
NFC.
Related issue number
n/a
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.