Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip reinstallation on windows due to constraints (#6756) #6759

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented May 19, 2022

This is a backport of PR #6756 as merged into master (72d3d4b).

What do these changes do?

Fix for constantly failing CI on windows agents.

Description

We have pinned pip version in constraints.txt file:

So when you call pip install ... -c constraints.txt it will downgrade/upgrade pip depending on the currently installed version. This works fine on all platforms except windows, which forces you to explicitly use python -m pip install ... when dealing with the pip package itself.

Since python -m pip install ... command is a completely legit replacement for pip install ... (examples from the pip wiki), I decided to update Makefile with it.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (3.9@d4814a9). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 72d3d4b differs from pull request most recent head ddd4405. Consider uploading reports for the commit ddd4405 to get more accurate results

@@          Coverage Diff           @@
##             3.9    #6759   +/-   ##
======================================
  Coverage       ?   93.44%           
======================================
  Files          ?      104           
  Lines          ?    30627           
  Branches       ?     3076           
======================================
  Hits           ?    28620           
  Misses         ?     1838           
  Partials       ?      169           
Flag Coverage Δ
unit 93.36% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4814a9...ddd4405. Read the comment docs.

@webknjaz webknjaz disabled auto-merge September 6, 2022 01:32
@webknjaz webknjaz changed the title [PR #6756/72d3d4b1 backport][3.9] Fix pip reinstallation on windows due to constraints Fix pip reinstallation on windows due to constraints (#6756) Sep 6, 2022
@webknjaz webknjaz merged commit 91d1961 into 3.9 Sep 6, 2022
@webknjaz webknjaz deleted the patchback/backports/3.9/72d3d4b1f68cca5ad15ef50bffb0419b798c7f23/pr-6756 branch September 6, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants