Add cov-dev makefile target #5576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5576 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 41 41
Lines 8863 8863
Branches 1425 1425
=======================================
Hits 8616 8616
Misses 130 130
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
webknjaz
reviewed
Mar 31, 2021
Makefile
Outdated
| .PHONY: cov-dev | ||
| cov-dev: .develop | ||
| @pytest --cov-report=html | ||
| @echo "open file://`pwd`/htmlcov/index.html" |
There was a problem hiding this comment.
This is macOS-only. There should be a fallback to xdg-open for GNU/Linux if we want this to be useful in general.
webknjaz
approved these changes
Mar 31, 2021
commonism
pushed a commit
to commonism/aiohttp
that referenced
this pull request
Apr 27, 2021
commonism
pushed a commit
to commonism/aiohttp
that referenced
this pull request
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add
cov-devtarget to makefile to run tests with coverage on dev host. Was removed in #5145, but stayed in docs. Just thought it's useful because now there is no way to get coverage except explicit pytest runAre there changes in behavior for the user?
No.
Related issue number
#5145
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.