-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci workflow timeout #5408
Fix ci workflow timeout #5408
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5408 +/- ##
==========================================
+ Coverage 97.15% 97.17% +0.02%
==========================================
Files 41 41
Lines 8742 8742
Branches 1402 1402
==========================================
+ Hits 8493 8495 +2
+ Misses 130 129 -1
+ Partials 119 118 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6ae77f5
to
aef3a17
Compare
e56fa8d
to
48d2837
Compare
@greshilov Do you want to explore using |
Looks like i have no choice. I'll try a few more times with |
036a35c
to
9ae468d
Compare
@webknjaz
|
This is a bad idea. Both files must be committed. Moreover, dependabot automatically recognizes the pairs of |
7479f42
to
523df30
Compare
@@ -30,6 +30,8 @@ repos: | |||
exclude: >- | |||
^docs/[^/]*\.svg$ | |||
- id: requirements-txt-fixer | |||
exclude: >- | |||
^requirements/dev.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^requirements/dev.txt | |
^requirements/dev.txt$ |
@pip-compile --allow-unsafe -q requirements/dev.in | ||
|
||
.PHONY: install | ||
install: .update-pip | ||
@pip install -Ur requirements/dev.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The canonical use of the lockfiles is as follows:
@pip install -Ur requirements/dev.txt | |
@pip install -r requirements/dev.in -c requirements/dev.txt |
Urgh... auto-merge got triggered when I posted comments :( |
@greshilov mind backporting this? |
Also, it's not clear how well dependabot works with files included via |
Strange behaviour. Should I create another PR with hotfixes? |
yes, please |
* Increase ci workflow timeout * Fix ci cache key typo * fixup! Increase ci workflow timeout * fixup! fixup! Increase ci workflow timeout
* Increase ci workflow timeout * Fix ci cache key typo * fixup! Increase ci workflow timeout * fixup! fixup! Increase ci workflow timeout
* Increase ci workflow timeout * Fix ci cache key typo * fixup! Increase ci workflow timeout * fixup! fixup! Increase ci workflow timeout
What do these changes do?
Increasing ci workflow timeout.
UPDATE Timeout is not changed, but
pip-tools
is used to pin dependencies and solve timeout issue.Are there changes in behavior for the user?
No.
Related issue number
Fixes #5389
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.This change is